Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4697)

Unified Diff: chrome/browser/extensions/extension_protocols.cc

Issue 55163006: Allow navigations performed by extensions to pass through AllowExtensionResourceLoad. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing the comment. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_protocols_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_protocols.cc
diff --git a/chrome/browser/extensions/extension_protocols.cc b/chrome/browser/extensions/extension_protocols.cc
index 217afa83238ef10c5bead8fe22719a03ab59f6de..2c184370b739c01f8f3f6b977f5adce6441d65bf 100644
--- a/chrome/browser/extensions/extension_protocols.cc
+++ b/chrome/browser/extensions/extension_protocols.cc
@@ -370,6 +370,12 @@ bool AllowExtensionResourceLoad(net::URLRequest* request,
return true;
}
+ // If the request is for navigations, then it should be allowed. The
+ // navigation logic in CrossSiteResourceHandler will properly transfer the
+ // navigation to a privileged process before it commits.
+ if (ResourceType::IsFrame(info->GetResourceType()))
Matt Perry 2013/11/01 19:16:10 Does this mean an arbitrary webpage can navigate a
+ return true;
+
// Extensions with webview: allow loading certain resources by guest renderers
// with privileged partition IDs as specified in the manifest file.
ExtensionRendererState* renderer_state =
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_protocols_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698