Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(962)

Issue 551543006: Remove unused files from webkitpy. (Closed)

Created:
6 years, 3 months ago by elecro
Modified:
6 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove unused files from webkitpy. Remove some left over files from the webkit days. BUG=none. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182227

Patch Set 1 #

Patch Set 2 : updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -595 lines) Patch
D Tools/Scripts/webkitpy/common/checkout/scm/commitmessage.py View 1 chunk +0 lines, -62 lines 0 comments Download
D Tools/Scripts/webkitpy/common/net/regressionwindow.py View 1 chunk +0 lines, -52 lines 0 comments Download
D Tools/Scripts/webkitpy/common/system/urlfetcher.py View 1 chunk +0 lines, -55 lines 0 comments Download
D Tools/Scripts/webkitpy/common/system/urlfetcher_mock.py View 1 chunk +0 lines, -46 lines 0 comments Download
D Tools/Scripts/webkitpy/common/system/zip_mock.py View 1 chunk +0 lines, -55 lines 0 comments Download
D Tools/Scripts/webkitpy/common/system/zipfileset.py View 1 1 chunk +0 lines, -71 lines 0 comments Download
D Tools/Scripts/webkitpy/common/system/zipfileset_mock.py View 1 chunk +0 lines, -51 lines 0 comments Download
D Tools/Scripts/webkitpy/common/system/zipfileset_unittest.py View 1 1 chunk +0 lines, -94 lines 0 comments Download
D Tools/Scripts/webkitpy/tool/commands/adduserstogroups.py View 1 chunk +0 lines, -65 lines 0 comments Download
D Tools/Scripts/webkitpy/tool/commands/findusers.py View 1 chunk +0 lines, -44 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
elecro
6 years, 3 months ago (2014-09-17 15:49:09 UTC) #2
Dirk Pranke
lgtm, but it looks like zipfileset.py and zipfileset_unittest.py are also no longer needed. Please delete ...
6 years, 3 months ago (2014-09-17 15:52:04 UTC) #3
elecro
On 2014/09/17 15:52:04, Dirk Pranke wrote: > lgtm, but it looks like zipfileset.py and zipfileset_unittest.py ...
6 years, 3 months ago (2014-09-17 16:12:50 UTC) #4
Dirk Pranke
On 2014/09/17 16:12:50, elecro wrote: > On 2014/09/17 15:52:04, Dirk Pranke wrote: > > lgtm, ...
6 years, 3 months ago (2014-09-17 16:14:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/551543006/20001
6 years, 3 months ago (2014-09-18 08:20:05 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 09:39:05 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 182227

Powered by Google App Engine
This is Rietveld 408576698