Issue 551543005: [turbofan] Allow encodable 64-bit constants as immediate for ARM64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 551543005: [turbofan] Allow encodable 64-bit constants as immediate for ARM64. (Closed)

Created:
6 years, 3 months ago by baptiste.afsa1

Modified:
6 years, 3 months ago

Reviewers:
Benedikt Meurer, ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan] Allow encodable 64-bit constants as immediate for ARM64. Also make sure that operands order for commutative 64-bit binary operations are properly swapped when the constant is on the left hand-side. R=bmeurer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24114

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+80 lines, -53 lines)			Patch
M	src/compiler/arm64/instruction-selector-arm64.cc	View	10 chunks	+23 lines, -17 lines	0 comments	Download
M	src/compiler/arm64/instruction-selector-arm64-unittest.cc	View	5 chunks	+53 lines, -36 lines	0 comments	Download
M	src/compiler/instruction-selector-unittest.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

baptiste.afsa1

6 years, 3 months ago (2014-09-22 12:32:41 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 24114 (presubmit successful).

Expand Messages | Collapse Messages