introduce Props to surface

include/core/SkSurface.h

 /*
  * Copyright 2012 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef SkSurface_DEFINED
 #define SkSurface_DEFINED
 
 #include "SkRefCnt.h"
 #include "SkImage.h"
+#include "SkSurfaceProps.h"
 
 class SkCanvas;
 class SkPaint;
 class GrContext;
 class GrRenderTarget;
 
 /**
  *  SkSurface represents the backend/results of drawing to a canvas. For raster
  *  drawing, the surface will be pixels, but (for example) when drawing into
  *  a PDF or Picture canvas, the surface stores the recorded commands.
  *
  *  To draw into a canvas, first create the appropriate type of Surface, and
  *  then request the canvas from the surface.
  */
 class SK_API SkSurface : public SkRefCnt {
 public:
     SK_DECLARE_INST_COUNT(SkSurface)
 
+    typedef SkSurfaceProps Props;
+
     /**
      *  Create a new surface, using the specified pixels/rowbytes as its
      *  backend.
      *
      *  If the requested surface cannot be created, or the request is not a
      *  supported configuration, NULL will be returned.
      */
-    static SkSurface* NewRasterDirect(const SkImageInfo&, void* pixels, size_t rowBytes);
+    static SkSurface* NewRasterDirect(const SkImageInfo&, void* pixels, size_t rowBytes,
+                                      const Props* = NULL);
 
     /**
      *  The same as NewRasterDirect, but also accepts a call-back routine, which is invoked
      *  when the surface is deleted, and is passed the pixel memory and the specified context.
      */
     static SkSurface* NewRasterDirectReleaseProc(const SkImageInfo&, void* pixels, size_t rowBytes,
                                                  void (*releaseProc)(void* pixels, void* context),
-                                                 void* context);
+                                                 void* context, const Props* = NULL);
 
     /**
      *  Return a new surface, with the memory for the pixels automatically
      *  allocated.
      *
      *  If the requested surface cannot be created, or the request is not a
      *  supported configuration, NULL will be returned.
      */
-    static SkSurface* NewRaster(const SkImageInfo&);
+    static SkSurface* NewRaster(const SkImageInfo&, const Props* = NULL);
 
     /**
      *  Helper version of NewRaster. It creates a SkImageInfo with the
      *  specified width and height, and populates the rest of info to match
      *  pixels in SkPMColor format.
      */
-    static SkSurface* NewRasterPMColor(int width, int height) {
-        return NewRaster(SkImageInfo::MakeN32Premul(width, height));
+    static SkSurface* NewRasterPMColor(int width, int height, const Props* props = NULL) {
+        return NewRaster(SkImageInfo::MakeN32Premul(width, height), props);
     }
 
     /**
      *  Text rendering modes that can be passed to NewRenderTarget*
      */
     enum TextRenderMode {
         /**
          *  This will use the standard text rendering method
          */
         kStandard_TextRenderMode,
@@ skipping 20 matching lines @@
                                             RenderTargetFlags flags = kNone_RenderTargetFlag);
 
     /**
      *  Return a new surface whose contents will be drawn to an offscreen
      *  render target, allocated by the surface.
      */
     static SkSurface* NewRenderTarget(GrContext*, const SkImageInfo&, int sampleCount = 0,
                                       TextRenderMode trm = kStandard_TextRenderMode,
                                       RenderTargetFlags flags = kNone_RenderTargetFlag);
 
+    static SkSurface* NewRenderTarget(GrContext*, const SkImageInfo&, int sampleCount,

[bsalomon, 2014/09/18 18:43:32]

Can we deprecate the above version? What do you think of moving the clear bit
into Props?

[reed1, 2014/09/18 21:03:12]

Done.

+                                      const SkSurfaceProps&,
+                                      RenderTargetFlags flags = kNone_RenderTargetFlag);
+
     /**
      *  Return a new surface whose contents will be drawn to an offscreen
      *  render target, allocated by the surface from the scratch texture pool
      *  managed by the GrContext. The scratch texture pool serves the purpose
      *  of retaining textures after they are no longer in use in order to
      *  re-use them later without having to re-allocate.  Scratch textures
      *  should be used in cases where high turnover is expected. This allows,
      *  for example, the copy on write to recycle a texture from a recently
      *  released SkImage snapshot of the surface.
      *  Note: Scratch textures count against the GrContext's cached resource
@@ skipping 83 matching lines @@
      *  RAM) return the const-address of those pixels, and if not null, return
      *  the ImageInfo and rowBytes. The returned address is only valid while
      *  the surface object is in scope, and no API call is made on the surface
      *  or its canvas.
      *
      *  On failure, returns NULL and the info and rowBytes parameters are
      *  ignored.
      */
     const void* peekPixels(SkImageInfo* info, size_t* rowBytes);
 
+    const Props& props() const { return fProps; }
+
 protected:
-    SkSurface(int width, int height);
-    SkSurface(const SkImageInfo&);
+    SkSurface(int width, int height, const Props*);
+    SkSurface(const SkImageInfo&, const Props*);
 
     // called by subclass if their contents have changed
     void dirtyGenerationID() {
         fGenerationID = 0;
     }
 
 private:
+    const Props fProps;
     const int   fWidth;
     const int   fHeight;
     uint32_t    fGenerationID;
 
     typedef SkRefCnt INHERITED;
 };
 
 #endif