tools/findit/common/http_client.py - Issue 551433003: [Findit] Fix network timeout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/findit/common/http_client.py

Issue 551433003: [Findit] Fix network timeout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase again. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/findit/common/http_client.py

diff --git a/tools/findit/common/http_client.py b/tools/findit/common/http_client.py

index 75dd410d0e7eb425e2ed56c540e62ca4042eb449..ae3349dac46d4b5641b5a761050556c2249d51e2 100644

--- a/tools/findit/common/http_client.py

+++ b/tools/findit/common/http_client.py

@@ -10,14 +10,14 @@ class HttpClient(object):

"""

@staticmethod

- def Get(url, params={}, timeout=60, retries=5, retry_interval=0.5,

+ def Get(url, params={}, timeout=120, retries=5, retry_interval=0.5,

retry_if_not=None):

"""Send a GET request to the given url with the given parameters.

Args:

url: the url to send request to.

params: parameters to send as part of the http request.

- timeout: timeout for the http request, default is 60 seconds.

+ timeout: timeout for the http request, default is 120 seconds.

retries: indicate how many retries before failing, default is 5.

retry_interval: interval in second to wait before retry, default is 0.5.

retry_if_not: a http status code. If set, retry only when the failed http

« no previous file with comments | « tools/findit/chromium_deps.py ('k') | tools/findit/common/http_client_local.py » ('j') | no next file with comments »