Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 # Copyright (c) 2014 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2014 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 import sys | 5 import sys |
| 6 | 6 |
| 7 import chromium_deps | 7 import chromium_deps |
| 8 from common import utils | 8 from common import utils |
| 9 import crash_utils | 9 import crash_utils |
| 10 import findit_for_crash as findit | 10 import findit_for_crash as findit |
| (...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 107 | 107 |
| 108 # Do not parse regression information for crashes introduced before the | 108 # Do not parse regression information for crashes introduced before the |
| 109 # first archived build. | 109 # first archived build. |
| 110 if chrome_regression_start != '0': | 110 if chrome_regression_start != '0': |
| 111 component_to_regression_dict = chromium_deps.GetChromiumComponentRange( | 111 component_to_regression_dict = chromium_deps.GetChromiumComponentRange( |
| 112 chrome_regression_start, chrome_regression_end) | 112 chrome_regression_start, chrome_regression_end) |
| 113 if not component_to_regression_dict: | 113 if not component_to_regression_dict: |
| 114 print ('Failed to get component regression ranges for chromium ' | 114 print ('Failed to get component regression ranges for chromium ' |
| 115 'regression range %s:%s' | 115 'regression range %s:%s' |
| 116 % (chrome_regression_start, chrome_regression_end)) | 116 % (chrome_regression_start, chrome_regression_end)) |
| 117 sys.exit(1) | 117 sys.exit(0) |
|
stgao
2014/09/06 03:25:19
If exit with 1, ClusterFuzz will show an exception
| |
| 118 | 118 |
| 119 # Parse crash revision. | 119 # Parse crash revision. |
| 120 if chrome_crash_revision: | 120 if chrome_crash_revision: |
| 121 component_to_crash_revision_dict = chromium_deps.GetChromiumComponents( | 121 component_to_crash_revision_dict = chromium_deps.GetChromiumComponents( |
| 122 chrome_crash_revision) | 122 chrome_crash_revision) |
| 123 if not component_to_crash_revision_dict: | 123 if not component_to_crash_revision_dict: |
| 124 print ('Failed to get component dependencies for chromium revision "%s".' | 124 print ('Failed to get component dependencies for chromium revision "%s".' |
| 125 % chrome_crash_revision) | 125 % chrome_crash_revision) |
| 126 sys.exit(1) | 126 sys.exit(0) |
| 127 | 127 |
| 128 # Check if component regression information is available. | 128 # Check if component regression information is available. |
| 129 component_regression = crash_utils.SplitRange(component_regression) | 129 component_regression = crash_utils.SplitRange(component_regression) |
| 130 if component_regression: | 130 if component_regression: |
| 131 component_regression_start = component_regression[0] | 131 component_regression_start = component_regression[0] |
| 132 component_regression_end = component_regression[1] | 132 component_regression_end = component_regression[1] |
| 133 | 133 |
| 134 # If this component already has an entry in parsed DEPS file, overwrite | 134 # If this component already has an entry in parsed DEPS file, overwrite |
| 135 # regression range and url. | 135 # regression range and url. |
| 136 if crashing_component_path in component_to_regression_dict: | 136 if crashing_component_path in component_to_regression_dict: |
| (...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 219 return ('No line information available in stacktrace.', []) | 219 return ('No line information available in stacktrace.', []) |
| 220 | 220 |
| 221 return ('Findit failed to find any stack trace. Is it in a new format?', []) | 221 return ('Findit failed to find any stack trace. Is it in a new format?', []) |
| 222 | 222 |
| 223 # Run the algorithm on the parsed stacktrace, and return the result. | 223 # Run the algorithm on the parsed stacktrace, and return the result. |
| 224 stacktrace_list = [parsed_release_build_stacktrace, | 224 stacktrace_list = [parsed_release_build_stacktrace, |
| 225 parsed_debug_build_stacktrace] | 225 parsed_debug_build_stacktrace] |
| 226 return findit.FindItForCrash( | 226 return findit.FindItForCrash( |
| 227 stacktrace_list, main_stack, component_to_regression_dict, | 227 stacktrace_list, main_stack, component_to_regression_dict, |
| 228 component_to_crash_revision_dict) | 228 component_to_crash_revision_dict) |
| OLD | NEW |