Issue 55143012: Renamed chrome/service/cloud_print/cloud_print_helpers* -> cloud_print_service_helpers

Issue 55143012: Renamed chrome/service/cloud_print/cloud_print_helpers* -> cloud_print_service_helpers (Closed)

Created:
7 years, 1 month ago by Vitaly Buka (NO REVIEWS)

Modified:
7 years, 1 month ago

Reviewers:
Mallinath (Gone from Chromium), Nico

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Renamed chrome/service/cloud_print/cloud_print_helpers* -> cloud_print_service_helpers File name the same as in chrome/common/cloud_print/ failed some VS builds. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232937

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -263 lines)			Patch
M	chrome/chrome.gyp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/service/cloud_print/cloud_print_connector.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/service/cloud_print/cloud_print_helpers.h	View		1 chunk	+0 lines, -43 lines	0 comments	Download
D	chrome/service/cloud_print/cloud_print_helpers.cc	View		1 chunk	+0 lines, -100 lines	0 comments	Download
D	chrome/service/cloud_print/cloud_print_helpers_unittest.cc	View		1 chunk	+0 lines, -105 lines	0 comments	Download
M	chrome/service/cloud_print/cloud_print_proxy_backend.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	chrome/service/cloud_print/cloud_print_service_helpers.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A +	chrome/service/cloud_print/cloud_print_service_helpers.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	chrome/service/cloud_print/cloud_print_service_helpers_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/service/cloud_print/cloud_print_url_fetcher.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/service/cloud_print/job_status_updater.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/service/cloud_print/print_system_cups.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/service/cloud_print/printer_job_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/service/cloud_print/printer_job_handler_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Mallinath (Gone from Chromium)

On 2013/11/04 22:25:54, Vitaly Buka wrote: lgtm

7 years, 1 month ago (2013-11-04 22:27:41 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/55143012/20016

7 years, 1 month ago (2013-11-04 22:49:26 UTC) #4

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) browser_tests, chrome_frame_net_tests, sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=219063

7 years, 1 month ago (2013-11-05 02:34:36 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/55143012/20016

7 years, 1 month ago (2013-11-05 06:49:33 UTC) #6

Message was sent while issue was closed.

Change committed as 232937

Expand Messages | Collapse Messages