Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 55143011: [sync] New strings for sign-in confirmation dialogs (Closed)

Created:
7 years, 1 month ago by Raghu Simha
Modified:
7 years, 1 month ago
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, pedrosimonetti+watch_chromium.org, Evan Stade
Visibility:
Public.

Description

[sync] New strings for sign-in confirmation dialogs This CL adds 2 new strings for the dialogs displayed when the user signs in for the first time. The strings will be consumed by the confirmation bubbles in a later CL, where we will need to increase the bubble width in addition to consuming the new strings. Strings: IDS_ONE_CLICK_SIGNIN_BUBBLE_MESSAGE_NEW IDS_SYNC_PROMO_NTP_BUBBLE_MESSAGE_NEW New text: Now that you're signed in, you can get your tabs, bookmarks and other Chrome stuff across your laptop, phone and tablet. You will also receive more relevant suggestions and features on Google services. BUG=314805 TEST=No UI changes. This CL just adds new strings. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232834

Patch Set 1 : #

Patch Set 2 : Merely add _NEW strings before string freeze. Undo actual UI changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M chrome/app/chromium_strings.grd View 1 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Raghu Simha
Folks, please review. rogerta@: Overall review. rpop@: string text. estade@: OWNERS approval for chrome/browser/ui/webui/ntp/ntp_login_handler.cc. I ...
7 years, 1 month ago (2013-11-04 22:27:06 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm
7 years, 1 month ago (2013-11-04 22:40:30 UTC) #2
Raghu Simha
After chatting offline with rogerta@, rpop@, and tmccoy@, we decided to merely add the new ...
7 years, 1 month ago (2013-11-04 23:15:02 UTC) #3
Roger Tawa OOO till Jul 10th
Still lgtm Thanks Raghu.
7 years, 1 month ago (2013-11-04 23:17:13 UTC) #4
rpop
7 years, 1 month ago (2013-11-04 23:17:27 UTC) #5
On 2013/11/04 23:15:02, Raghu Simha wrote:
> After chatting offline with rogerta@, rpop@, and tmccoy@, we decided to merely
> add the new strings with a _NEW suffix, and to actually hook them up to the UI
> in a later patch.
> 
> Moving estade@ to cc.
> 
> rogerta@, rpop@, tmccoy@: PTAL.

lgtm

Powered by Google App Engine
This is Rietveld 408576698