Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 55143010: Fixing V2 application issues on M-32 for the M-31 legacy multi user mode. (Closed)

Created:
7 years, 1 month ago by Mr4D (OOO till 08-26)
Modified:
7 years, 1 month ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

Fixing V2 application issues on M-32 for the M-31 legacy multi user mode. This is a fix for the old M-31 multi profile mode in M-32. BUG=314286 TEST=visual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232996

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -5 lines) Patch
M chrome/browser/ui/ash/launcher/shell_window_launcher_controller.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/shell_window_launcher_controller.cc View 1 4 chunks +30 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Mr4D (OOO till 08-26)
Please have a look!
7 years, 1 month ago (2013-11-04 19:32:17 UTC) #1
Daniel Erat
lgtm https://codereview.chromium.org/55143010/diff/1/chrome/browser/ui/ash/launcher/shell_window_launcher_controller.cc File chrome/browser/ui/ash/launcher/shell_window_launcher_controller.cc (right): https://codereview.chromium.org/55143010/diff/1/chrome/browser/ui/ash/launcher/shell_window_launcher_controller.cc#newcode75 chrome/browser/ui/ash/launcher/shell_window_launcher_controller.cc:75: // this mode gets no longer persued this ...
7 years, 1 month ago (2013-11-04 20:16:22 UTC) #2
Mr4D (OOO till 08-26)
Thanks for the quick review! https://codereview.chromium.org/55143010/diff/1/chrome/browser/ui/ash/launcher/shell_window_launcher_controller.cc File chrome/browser/ui/ash/launcher/shell_window_launcher_controller.cc (right): https://codereview.chromium.org/55143010/diff/1/chrome/browser/ui/ash/launcher/shell_window_launcher_controller.cc#newcode75 chrome/browser/ui/ash/launcher/shell_window_launcher_controller.cc:75: // this mode gets ...
7 years, 1 month ago (2013-11-04 20:21:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/55143010/50001
7 years, 1 month ago (2013-11-04 20:29:22 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=218879
7 years, 1 month ago (2013-11-05 00:42:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/55143010/50001
7 years, 1 month ago (2013-11-05 00:56:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/55143010/50001
7 years, 1 month ago (2013-11-05 03:16:10 UTC) #7
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-05 04:24:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/55143010/50001
7 years, 1 month ago (2013-11-05 04:47:36 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=184894
7 years, 1 month ago (2013-11-05 07:42:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/55143010/50001
7 years, 1 month ago (2013-11-05 15:05:40 UTC) #11
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 16:11:19 UTC) #12
Message was sent while issue was closed.
Change committed as 232996

Powered by Google App Engine
This is Rietveld 408576698