Move MIMEType classes to Source/platform

Move MIMEType classes to Source/platform

BUG=297477
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161388

[rwlbuis, 2013-11-04 17:12:19]

I noticed some classes in platform/graphics rely on MIMETypeRegistry.h so move
it to Source/platform first.

[abarth-chromium, 2013-11-04 17:22:56]

You've moved MIMETypeRegistry.h but you haven't moved
MIMETypeRegistryChromium.cpp.  I suspect this CL doesn't compile.  Please move
MIMETypeRegistryChromium.cpp to Source/platform/MIMETypeRegistry.cpp as well.

[abarth-chromium, 2013-11-04 17:23:24]

https://codereview.chromium.org/55143009/diff/1/Source/platform/blink_platfor...
File Source/platform/blink_platform.gypi (right):

https://codereview.chromium.org/55143009/diff/1/Source/platform/blink_platfor...
Source/platform/blink_platform.gypi:58: 'MIMETypeFromURL.h',
Also, please add all files to the GYP.  For example, MIMETypeRegistry.h is
missing.

[Stephen Chennney, 2013-11-04 17:42:41]

On 2013/11/04 17:22:56, abarth wrote:
> You've moved MIMETypeRegistry.h but you haven't moved
> MIMETypeRegistryChromium.cpp.  I suspect this CL doesn't compile.  Please move
> MIMETypeRegistryChromium.cpp to Source/platform/MIMETypeRegistry.cpp as well.

Do we have any policy for removing ...Chromium files entirely and merging them
into the primary files? I think we can go ahead and do that now.

[rwlbuis, 2013-11-04 18:06:00]

On 2013/11/04 17:22:56, abarth wrote:
> You've moved MIMETypeRegistry.h but you haven't moved
> MIMETypeRegistryChromium.cpp.  I suspect this CL doesn't compile.  Please move
> MIMETypeRegistryChromium.cpp to Source/platform/MIMETypeRegistry.cpp as well.

It compiled fine for me. However that sounds like a good suggestion, will do.

[abarth-chromium, 2013-11-04 18:26:53]

On 2013/11/04 17:42:41, Stephen Chenney wrote:
> Do we have any policy for removing ...Chromium files entirely and merging them
> into the primary files? I think we can go ahead and do that now.

Yes!  We should definitely do that.  There shouldn't be any mention of
"chromium" in Blink in the long term.  (Well, except in some GL code...)

[rwlbuis, 2013-11-04 19:55:38]

On 2013/11/04 18:26:53, abarth wrote:
> On 2013/11/04 17:42:41, Stephen Chenney wrote:
> > Do we have any policy for removing ...Chromium files entirely and merging
them
> > into the primary files? I think we can go ahead and do that now.
> 
> Yes!  We should definitely do that.  There shouldn't be any mention of
> "chromium" in Blink in the long term.  (Well, except in some GL code...)

Ok I did that in my latest changeset. However note that the PluginData.h
dependency means moving two plugin classes. Also note that PluginListBuilder
could be folded into PluginData as it is the only user.

[Stephen Chennney, 2013-11-05 16:27:29]

lgtm

[abarth-chromium, 2013-11-05 19:18:50]

rsLGTM

[commit-bot: I haz the power, 2013-11-05 19:22:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/55143009/100001

[commit-bot: I haz the power, 2013-11-05 20:37:29]

Failed to apply patch for Source/core/dom/DOMImplementation.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/dom/DOMImplementation.cpp
  Hunk #1 FAILED at 47.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/dom/DOMImplementation.cpp.rej

Patch:       Source/core/dom/DOMImplementation.cpp
Index: Source/core/dom/DOMImplementation.cpp
diff --git a/Source/core/dom/DOMImplementation.cpp
b/Source/core/dom/DOMImplementation.cpp
index
756cbb1c928f9483460534004687c92fe8d21827..9f2d3bb1ce50148aeeeb209b1fa7836d43662782
100644
--- a/Source/core/dom/DOMImplementation.cpp
+++ b/Source/core/dom/DOMImplementation.cpp
@@ -47,12 +47,12 @@
 #include "core/loader/FrameLoader.h"
 #include "core/frame/Frame.h"
 #include "core/page/Page.h"
-#include "core/platform/MIMETypeRegistry.h"
 #include "core/platform/graphics/Image.h"
 #include "core/platform/graphics/MediaPlayer.h"
-#include "core/plugins/PluginData.h"
 #include "core/svg/SVGDocument.h"
 #include "platform/ContentType.h"
+#include "platform/MIMETypeRegistry.h"
+#include "platform/plugins/PluginData.h"
 #include "weborigin/SecurityOrigin.h"
 #include "wtf/StdLibExtras.h"

[commit-bot: I haz the power, 2013-11-05 20:57:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/55143009/230001

[commit-bot: I haz the power, 2013-11-05 22:46:08]

Change committed as 161388

[GBaby, 2016-11-15 17:55:35]

geranebaker@gmail.com changed reviewers:
+ geranebaker@gmail.com