Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 551423002: [MIPS64] Add build support for MIPS64 in libjpeg_turbo. (Closed)

Created:
6 years, 3 months ago by gordanac
Modified:
6 years, 3 months ago
Reviewers:
szager, cmp, iannucci, Noel Gordon, mmoss, gordana.cmiljanovic
CC:
petar.jovanovic, Paul Lind
Base URL:
https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git@master
Visibility:
Public.

Description

[MIPS64] Add build support for MIPS64 in libjpeg_turbo. BUG=400684

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M libjpeg.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (6 generated)
gordanac
Please take a look.
6 years, 3 months ago (2014-09-09 14:06:44 UTC) #2
Noel Gordon
lgtm
6 years, 3 months ago (2014-09-10 00:32:11 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
6 years, 3 months ago (2014-09-10 09:15:50 UTC) #6
gordanac
On 2014/09/10 09:15:50, I haz the power (commit-bot) wrote: > Commit queue rejected this change ...
6 years, 3 months ago (2014-09-10 09:35:02 UTC) #7
Noel Gordon
http://www.chromium.org/developers/how-tos/get-the-code#TOC-Working-with-repositories-in-subdirectories-other-than-the-main-Chromium-repository Follow the instructions there for checkout and submit for a third-party directory.
6 years, 3 months ago (2014-09-10 10:42:29 UTC) #8
gordanac
On 2014/09/10 10:42:29, Noel Gordon wrote: > http://www.chromium.org/developers/how-tos/get-the-code#TOC-Working-with-repositories-in-subdirectories-other-than-the-main-Chromium-repository > > Follow the instructions there for ...
6 years, 3 months ago (2014-09-10 15:07:55 UTC) #9
Noel Gordon
Things might have changed since chrome switch to git.
6 years, 3 months ago (2014-09-11 00:28:34 UTC) #10
Noel Gordon
+Chase, the instructions seem out-of-date. How should we submit into a third party these days?
6 years, 3 months ago (2014-09-11 00:33:17 UTC) #12
cmp
On 2014/09/11 00:33:17, Noel Gordon wrote: > +Chase, the instructions seem out-of-date. How should we ...
6 years, 3 months ago (2014-09-11 20:49:23 UTC) #15
Noel Gordon
Right thanks, I did try the instructions on http://www.chromium.org/developers/how-tos/get-the-code#TOC-Working-with-repositories-in-subdirectories-other-than-the-main-Chromium-repository they've worked for me in the ...
6 years, 3 months ago (2014-09-12 07:07:01 UTC) #16
Noel Gordon
Landed manually on https://codereview.appspot.com/143920043
6 years, 3 months ago (2014-09-13 15:26:17 UTC) #17
gordanac
On 2014/09/13 15:26:17, Noel Gordon wrote: > Landed manually on https://codereview.appspot.com/143920043 Many thanks!
6 years, 3 months ago (2014-09-15 09:29:15 UTC) #18
Noel Gordon
6 years, 3 months ago (2014-09-15 11:06:39 UTC) #19
Message was sent while issue was closed.
np, and thank to mmoss@ for helping me land it.

Powered by Google App Engine
This is Rietveld 408576698