|
|
Created:
6 years, 3 months ago by gordanac Modified:
6 years, 3 months ago CC:
petar.jovanovic, Paul Lind Base URL:
https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git@master Visibility:
Public. |
Description[MIPS64] Add build support for MIPS64 in libjpeg_turbo.
BUG=400684
Patch Set 1 #
Messages
Total messages: 19 (6 generated)
gordana.cmiljanovic@imgtec.com changed reviewers: + noel@chromium.org
Please take a look.
lgtm
The CQ bit was checked by gordana.cmiljanovic@imgtec.com
The CQ bit was unchecked by commit-bot@chromium.org
Commit queue rejected this change because it did not recognize the base URL. Please commit your change manually.
On 2014/09/10 09:15:50, I haz the power (commit-bot) wrote: > Commit queue rejected this change because it did not recognize the base URL. > Please commit your change manually. Please help to commit this change.
http://www.chromium.org/developers/how-tos/get-the-code#TOC-Working-with-repo... Follow the instructions there for checkout and submit for a third-party directory.
On 2014/09/10 10:42:29, Noel Gordon wrote: > http://www.chromium.org/developers/how-tos/get-the-code#TOC-Working-with-repo... > > Follow the instructions there for checkout and submit for a third-party > directory. I followed the instructions and tried to commit using 'git cl dcommit', however, it failed with error: "Password for 'Gordana.Cmiljanovic@imgtec.com': Authorization failed: Authentication error from server: Username not found at /usr/lib/git-core/git-svn line 920 Failed to push. If this persists, please file a bug." Please note that I am not a committer and do not have Google Chrome svn account so I cannot register svn credentials locally to bypass this error.
Things might have changed since chrome switch to git.
noel@chromium.org changed reviewers: + cmp@chromium.org, gordana.cmiljanovic@imgtec.com - Gordana.Cmiljanovic@imgtec.com
+Chase, the instructions seem out-of-date. How should we submit into a third party these days?
noel@chromium.org changed reviewers: + iannucci@chromium.org
cmp@chromium.org changed reviewers: + mmoss@google.com, szager@google.com
On 2014/09/11 00:33:17, Noel Gordon wrote: > +Chase, the instructions seem out-of-date. How should we submit into a third > party these days? Adding mmoss and szager. (Robbie's already on this CL.) Since gordanac@ is not a committer, that will be the reason why the git cl dcommit failed. This path (svn://svn.chromium.org/chrome/trunk/deps/third_party/libjpeg_turbo) continues to be valid for landing Chromium third_party changes. The Chromium Git migration only moved chrome/trunk/src and most release branches and tags to Git. We'll migrate these other paths later on. Until then, please continue using git-svn to land changes like this or relying on Chromium committers to land the changes on your behalf.
Right thanks, I did try the instructions on http://www.chromium.org/developers/how-tos/get-the-code#TOC-Working-with-repo... they've worked for me in the past, but not working for me anymore. The setup / fetch appears to work. Make a local change, commit locally, then upload to reitveld ... % git cl upload fatal: ref HEAD is not a symbolic ref Command "git symbolic-ref HEAD" failed.
Landed manually on https://codereview.appspot.com/143920043
Message was sent while issue was closed.
On 2014/09/13 15:26:17, Noel Gordon wrote: > Landed manually on https://codereview.appspot.com/143920043 Many thanks!
Message was sent while issue was closed.
np, and thank to mmoss@ for helping me land it. |