Issue 551413002: Switch inlining to use simplified instead of machine loads.

Issue 551413002: Switch inlining to use simplified instead of machine loads. (Closed)

Created:
6 years, 3 months ago by Michael Starzinger

Modified:
6 years, 3 months ago

Reviewers:
sigurds

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Switch inlining to use simplified instead of machine loads. R=sigurds@chromium.org TEST=cctest/test-run-inlining --turbo-types Committed: https://code.google.com/p/v8/source/detail?r=23813

Patch Set 2 : Adapt test cases. #

Total comments: 2

Patch Set 3 : Addressed comments by Sigurd. #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -16 lines)			Patch
M	src/compiler/access-builder.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/compiler/access-builder.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/compiler/js-inlining.cc	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	test/cctest/cctest.status	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	test/cctest/compiler/test-run-inlining.cc	View	1	13 chunks	+26 lines, -13 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sigurds

LGTM (please fix typo) https://codereview.chromium.org/551413002/diff/20001/test/cctest/cctest.status File test/cctest/cctest.status (right): https://codereview.chromium.org/551413002/diff/20001/test/cctest/cctest.status#newcode97 test/cctest/cctest.status:97: # TODO(sigurd): The schedule is ...

6 years, 3 months ago (2014-09-09 15:31:39 UTC) #2

Michael Starzinger

Addressed comments. Thanks for review. Landing. https://codereview.chromium.org/551413002/diff/20001/test/cctest/cctest.status File test/cctest/cctest.status (right): https://codereview.chromium.org/551413002/diff/20001/test/cctest/cctest.status#newcode97 test/cctest/cctest.status:97: # TODO(sigurd): The ...

6 years, 3 months ago (2014-09-09 15:35:38 UTC) #3

Michael Starzinger

6 years, 3 months ago (2014-09-09 15:55:58 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as 23813 (presubmit successful).

Expand Messages | Collapse Messages