Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(880)

Issue 551403002: Set autofilled property after atuofilled value is set. (Closed)

Created:
6 years, 3 months ago by ziran.sun
Modified:
6 years, 3 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, jam, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Set autofilled property after autofilled value is set. Autofill preview sets the field's autofill property to true. When the field is autofilled right after preview happens, we'd like to clear the autofill property that was set by preview before filling happens. This is handled in Blink side in SetValue() function - https://codereview.chromium.org/553983012/ R=isherman@chromium.org BUG=412311 Committed: https://crrev.com/ae2e0995efb0d27ea19d7861a0952112a46d5931 Cr-Commit-Position: refs/heads/master@{#295955}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/autofill/content/renderer/form_autofill_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Ilya Sherman
LGTM. Apologies, I somehow missed this review request.
6 years, 3 months ago (2014-09-20 00:54:06 UTC) #1
Ilya Sherman
On 2014/09/20 00:54:06, Ilya Sherman wrote: > LGTM. Apologies, I somehow missed this review request. ...
6 years, 3 months ago (2014-09-20 00:55:52 UTC) #2
ziran.sun
On 2014/09/20 00:55:52, Ilya Sherman wrote: > On 2014/09/20 00:54:06, Ilya Sherman wrote: > > ...
6 years, 3 months ago (2014-09-22 09:07:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/551403002/1
6 years, 3 months ago (2014-09-22 09:08:59 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-22 11:09:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/551403002/1
6 years, 3 months ago (2014-09-22 12:37:40 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as d651049996bde8bc68296716b93ab4866c1ccf72
6 years, 3 months ago (2014-09-22 12:49:13 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 12:49:55 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ae2e0995efb0d27ea19d7861a0952112a46d5931
Cr-Commit-Position: refs/heads/master@{#295955}

Powered by Google App Engine
This is Rietveld 408576698