Crash fix + OS specific ss's enabled.

Crash fix + OS specific ss's enabled.
Fixes a crash in which if a feedback tab is open and a user opens it from a different tab again, feedback will crash on sending a report. This is due to browser_navigator; this change decouples us from the Singleton tab logic and adds our own.

Additionally, code to take screenshots on other platforms is also added.

BUG=64971, 61847
TEST=Tested by opening feedback from multiple tabs; sent reports successfully. Additionally tested with sending screenshots from Linux.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68052

[oshima, 2010-12-02 18:03:30]

http://codereview.chromium.org/5514001/diff/6001/chrome/browser/dom_ui/bug_re...
File chrome/browser/dom_ui/bug_report_ui.cc (right):

http://codereview.chromium.org/5514001/diff/6001/chrome/browser/dom_ui/bug_re...
chrome/browser/dom_ui/bug_report_ui.cc:127: if (bug_report_url ==
tab->GetURL().GetWithEmptyPath())
if (tab && tab->GetURL().GetWithEmptyPath() == bug_report_url)

http://codereview.chromium.org/5514001/diff/6001/chrome/browser/dom_ui/bug_re...
chrome/browser/dom_ui/bug_report_ui.cc:216: } // namespace browser
two spaces before //

http://codereview.chromium.org/5514001/diff/6001/chrome/browser/dom_ui/bug_re...
File chrome/browser/dom_ui/bug_report_ui.h (right):

http://codereview.chromium.org/5514001/diff/6001/chrome/browser/dom_ui/bug_re...
chrome/browser/dom_ui/bug_report_ui.h:11: #include "gfx/rect.h"
You should be able to forward declarations for Window/Browser/Rect types.

http://codereview.chromium.org/5514001/diff/6001/chrome/browser/dom_ui/bug_re...
chrome/browser/dom_ui/bug_report_ui.h:24: #endif
These are ugly. Ideally, screenshot code should be in BrowserWindow and this can
be like

ShowHtmlBugReportView(Browser* browser) {
  screenshort = browser->window()->TakeScreenShot();
}

This way, you can avoid using ifdefs.

I understand that this has to be this way in order to merge to M9, so please
file a bug and fix this for M10 once M9 is done.

Also, please remove macox.

http://codereview.chromium.org/5514001/diff/6001/chrome/browser/dom_ui/bug_re...
chrome/browser/dom_ui/bug_report_ui.h:25: } // namespace browser
two spaces before //

http://codereview.chromium.org/5514001/diff/6001/chrome/browser/resources/bug...
File chrome/browser/resources/bug_report.html (right):

http://codereview.chromium.org/5514001/diff/6001/chrome/browser/resources/bug...
chrome/browser/resources/bug_report.html:25: };
please use if () {} for multi-line

[oshima, 2010-12-02 18:04:12]

http://codereview.chromium.org/5514001/diff/6001/chrome/browser/dom_ui/bug_re...
File chrome/browser/dom_ui/bug_report_ui.h (right):

http://codereview.chromium.org/5514001/diff/6001/chrome/browser/dom_ui/bug_re...
chrome/browser/dom_ui/bug_report_ui.h:24: #endif
forgot to mention. please add comment and include bugid.

On 2010/12/02 18:03:30, oshima wrote:
> These are ugly. Ideally, screenshot code should be in BrowserWindow and this
can
> be like
> 
> ShowHtmlBugReportView(Browser* browser) {
>   screenshort = browser->window()->TakeScreenShot();
> }
> 
> This way, you can avoid using ifdefs.
> 
> I understand that this has to be this way in order to merge to M9, so please
> file a bug and fix this for M10 once M9 is done.
> 
> Also, please remove macox.

[rkc, 2010-12-02 19:54:04]

http://codereview.chromium.org/5514001/diff/6001/chrome/browser/dom_ui/bug_re...
File chrome/browser/dom_ui/bug_report_ui.cc (right):

http://codereview.chromium.org/5514001/diff/6001/chrome/browser/dom_ui/bug_re...
chrome/browser/dom_ui/bug_report_ui.cc:127: if (bug_report_url ==
tab->GetURL().GetWithEmptyPath())
On 2010/12/02 18:03:30, oshima wrote:
> if (tab && tab->GetURL().GetWithEmptyPath() == bug_report_url)

Done.

http://codereview.chromium.org/5514001/diff/6001/chrome/browser/dom_ui/bug_re...
chrome/browser/dom_ui/bug_report_ui.cc:216: } // namespace browser
On 2010/12/02 18:03:30, oshima wrote:
> two spaces before //

Done.

http://codereview.chromium.org/5514001/diff/6001/chrome/browser/dom_ui/bug_re...
File chrome/browser/dom_ui/bug_report_ui.h (right):

http://codereview.chromium.org/5514001/diff/6001/chrome/browser/dom_ui/bug_re...
chrome/browser/dom_ui/bug_report_ui.h:11: #include "gfx/rect.h"
On 2010/12/02 18:03:30, oshima wrote:
> You should be able to forward declarations for Window/Browser/Rect types.

Done.

http://codereview.chromium.org/5514001/diff/6001/chrome/browser/dom_ui/bug_re...
chrome/browser/dom_ui/bug_report_ui.h:24: #endif
On 2010/12/02 18:03:30, oshima wrote:
> These are ugly. Ideally, screenshot code should be in BrowserWindow and this
can
> be like
> 
> ShowHtmlBugReportView(Browser* browser) {
>   screenshort = browser->window()->TakeScreenShot();
> }
> 
> This way, you can avoid using ifdefs.
> 
> I understand that this has to be this way in order to merge to M9, so please
> file a bug and fix this for M10 once M9 is done.
> 
> Also, please remove macox.

Done.

http://codereview.chromium.org/5514001/diff/6001/chrome/browser/dom_ui/bug_re...
chrome/browser/dom_ui/bug_report_ui.h:24: #endif
On 2010/12/02 18:03:30, oshima wrote:
> These are ugly. Ideally, screenshot code should be in BrowserWindow and this
can
> be like
> 
> ShowHtmlBugReportView(Browser* browser) {
>   screenshort = browser->window()->TakeScreenShot();
> }
> 
> This way, you can avoid using ifdefs.
> 
> I understand that this has to be this way in order to merge to M9, so please
> file a bug and fix this for M10 once M9 is done.
> 
> Also, please remove macox.

We can't remove MacOS since this file, even though not used, is still compiled
for a Mac; I am not sure why, but since this code will get refactored anyway,
this should not be a problem later.

(rest)
Done.

http://codereview.chromium.org/5514001/diff/6001/chrome/browser/dom_ui/bug_re...
chrome/browser/dom_ui/bug_report_ui.h:25: } // namespace browser
On 2010/12/02 18:03:30, oshima wrote:
> two spaces before //

Done.

http://codereview.chromium.org/5514001/diff/6001/chrome/browser/resources/bug...
File chrome/browser/resources/bug_report.html (right):

http://codereview.chromium.org/5514001/diff/6001/chrome/browser/resources/bug...
chrome/browser/resources/bug_report.html:25: };
On 2010/12/02 18:03:30, oshima wrote:
> please use if () {} for multi-line

Done.

[oshima, 2010-12-02 20:01:35]

LGTM, given the constraints we have, but 
if this code is compiled for mac as well, it's really strange because mac
shouldn't be using views.