Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 551393003: Declaring the weak_ptr_factory in proper order. (Closed)

Created:
6 years, 3 months ago by Anand Ratn (left samsung)
Modified:
6 years, 3 months ago
Reviewers:
Wez
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Declaring the weak_ptr_factory in proper order. Cleaning up weak_ptr_factory destruction order in "src/remoting" module. WeakPtrFactory should remain the last member so it'll be destroyed and invalidate its weak pointers before any other members are destroyed. BUG=303818 Committed: https://crrev.com/a36f5b520abe7ce7dc32adae53e36fef4881321c Cr-Commit-Position: refs/heads/master@{#294331}

Patch Set 1 #

Patch Set 2 : Updating files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M remoting/host/ipc_desktop_environment.h View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/host/ipc_desktop_environment.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Anand Ratn (left samsung)
dcaiafa@chromium.org: Please review changes in src/remoting module. rmsousa@chromium.org: Please review changes in src/remoting module. darin@chromium.org: ...
6 years, 3 months ago (2014-09-09 14:36:07 UTC) #2
Wez
On 2014/09/09 14:36:07, anand.ratn wrote: > mailto:dcaiafa@chromium.org: Please review changes in src/remoting module. > > ...
6 years, 3 months ago (2014-09-10 23:17:45 UTC) #5
Wez
LGTM
6 years, 3 months ago (2014-09-10 23:18:17 UTC) #6
Anand Ratn (left samsung)
On 2014/09/10 23:17:45, Wez wrote: > On 2014/09/09 14:36:07, anand.ratn wrote: > > mailto:dcaiafa@chromium.org: Please ...
6 years, 3 months ago (2014-09-11 03:11:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/551393003/20001
6 years, 3 months ago (2014-09-11 03:12:14 UTC) #11
Wez
On 2014/09/11 03:11:06, anand.ratn wrote: > On 2014/09/10 23:17:45, Wez wrote: > > On 2014/09/09 ...
6 years, 3 months ago (2014-09-11 04:00:06 UTC) #12
Anand Ratn (left samsung)
On 2014/09/11 04:00:06, Wez wrote: > On 2014/09/11 03:11:06, anand.ratn wrote: > > On 2014/09/10 ...
6 years, 3 months ago (2014-09-11 04:04:20 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as ab68ba74fb9a5dd39f2ab9d496dadc615d7c294d
6 years, 3 months ago (2014-09-11 05:53:34 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 05:57:41 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a36f5b520abe7ce7dc32adae53e36fef4881321c
Cr-Commit-Position: refs/heads/master@{#294331}

Powered by Google App Engine
This is Rietveld 408576698