Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 551373008: Subzero: Make the szbuild.py script more automatic. (Closed)

Created:
6 years, 3 months ago by Jim Stichnoth
Modified:
6 years, 3 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Subzero: Make the szbuild.py script more automatic. One wants to omit the --init option to make things go faster, but then there's the risk that the pexe or llvm2ice or llc has changed and --init is actually necessary. This change automatically compares the modification timestamps of the pexe and the llvm2ice and llc binaries against the modification timestamps of the object files to determine whether re-translation is needed. The --init option forces re-translation regardless of timestamps. BUG= none R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=0fb613f88e44dc877a1b99cf324af6809a8391fd

Patch Set 1 #

Patch Set 2 : Doc cleanup #

Total comments: 2

Patch Set 3 : Change --init to --force #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -17 lines) Patch
M pydir/szbuild.py View 1 2 6 chunks +34 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Jim Stichnoth
6 years, 3 months ago (2014-09-16 00:30:26 UTC) #2
jvoung (off chromium)
lgtm https://codereview.chromium.org/551373008/diff/20001/pydir/szbuild.py File pydir/szbuild.py (right): https://codereview.chromium.org/551373008/diff/20001/pydir/szbuild.py#newcode109 pydir/szbuild.py:109: help='Force all re-translation of the pexe') Would it ...
6 years, 3 months ago (2014-09-16 00:43:58 UTC) #3
Jim Stichnoth
https://codereview.chromium.org/551373008/diff/20001/pydir/szbuild.py File pydir/szbuild.py (right): https://codereview.chromium.org/551373008/diff/20001/pydir/szbuild.py#newcode109 pydir/szbuild.py:109: help='Force all re-translation of the pexe') On 2014/09/16 00:43:58, ...
6 years, 3 months ago (2014-09-16 03:09:48 UTC) #4
Jim Stichnoth
6 years, 3 months ago (2014-09-16 17:19:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 0fb613f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698