content/browser/renderer_host/render_widget_host_view_aura_unittest.cc - Issue 551373006: Re-enable Eager Gesture Recognition on Aura

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

Issue 551373006: Re-enable Eager Gesture Recognition on Aura (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address sadrul's comments. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_aura.cc ('k') | content/browser/web_contents/web_contents_view_aura_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

index 2153b2e733f6d9d79dd161569e08d20fa1e5a216..79280705ce6bcd448b5c15407b15b9170755e955 100644

--- a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

+++ b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

@@ -942,6 +942,7 @@ TEST_F(RenderWidgetHostViewAuraTest, FinishCompositionByMouse) {

// Checks that touch-event state is maintained correctly.

TEST_F(RenderWidgetHostViewAuraTest, TouchEventState) {

view_->InitAsChild(NULL);

+ aura_test_helper_->root_window()->AddChild(view_->window());

view_->Show();

// Start with no touch-event handler in the renderer.

@@ -1050,6 +1051,7 @@ TEST_F(RenderWidgetHostViewAuraTest, TouchEventState) {

// handler on the page.

TEST_F(RenderWidgetHostViewAuraTest, TouchEventSyncAsync) {

view_->InitAsChild(NULL);

+ aura_test_helper_->root_window()->AddChild(view_->window());

view_->Show();

widget_host_->OnMessageReceived(ViewHostMsg_HasTouchEventHandlers(0, true));

@@ -1992,6 +1994,7 @@ TEST_F(RenderWidgetHostViewAuraTest, TouchEventPositionsArentRounded) {

const float kY = 50.23f;

view_->InitAsChild(NULL);

+ aura_test_helper_->root_window()->AddChild(view_->window());

view_->Show();

ui::TouchEvent press(ui::ET_TOUCH_PRESSED,