DescriptionEnable ash shell and unit tests in GN build.
Update ash gyp files. There were some obsolete 'sources!' entries and a non-test file accidentally in the ash unittests sources.
workspace_backdrop_delegate.cc was duplicated in both ash and the unit tests target. Apparetcly this was done to make the component build work because it didn't have the export designation. The GN build detected this because it uses source_set instead of static_library which caught the duplicate symbol. This adds the export designation, removes the duplicate, and also adds ash_export.h to the sources list.
There were some warnings about superfluous const usage that surfaced. I assume this file isn't being compiled with chromium_code in the GYP build.
Committed: https://crrev.com/ea76f5f5c3d6e0f73876d040265ad121346e9f3d
Cr-Commit-Position: refs/heads/master@{#294030}
Patch Set 1 #Patch Set 2 : #Patch Set 3 : #Patch Set 4 : non-exported base for windows #
Messages
Total messages: 10 (4 generated)
|