Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 551373003: Removed unregisterTerminationObserver from DatabaseContext::contextDestroyed (Closed)

Created:
6 years, 3 months ago by kozyatinskiy1
Modified:
6 years, 3 months ago
Reviewers:
tkent, vsevik
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Removed unregisterTerminationObserver from DatabaseContext::contextDestroyed Method DatabaseContext::contextDestroyed always calls from ExecutionContext destructor. In the case when the context is WorkerGlobalScope - from WorkerGlobalScope destructor. This unregister call does nothing in this situation. And it looks dangerous when we try to use the methods of the object in destructor. E.g. if we make the method ExecutionContext::isWorkerGlobalScope virtual the program will crash in DatabaseContext::contextDestroyed. R=tkent@chromium.org,vsevik@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181711

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M Source/core/workers/WorkerGlobalScope.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/workers/WorkerGlobalScope.cpp View 1 1 chunk +0 lines, -7 lines 0 comments Download
M Source/modules/webdatabase/DatabaseContext.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
kozyatinskiy1
Hi. Please take a look. You added lines with unregisterTerminationObserver in https://codereview.chromium.org/248523003 I'm working on ...
6 years, 3 months ago (2014-09-09 12:45:35 UTC) #1
tkent
lgtm We can remove WorkerGlobalScope::unregisterTerminationObserver too. There are no other callsites.
6 years, 3 months ago (2014-09-09 23:25:44 UTC) #2
kozyatinskiy1
On 2014/09/09 23:25:44, tkent (overloaded) wrote: > lgtm > We can remove WorkerGlobalScope::unregisterTerminationObserver too. There ...
6 years, 3 months ago (2014-09-10 06:42:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kozyatinskiy@google.com/551373003/20001
6 years, 3 months ago (2014-09-10 06:43:54 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 08:06:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 181711

Powered by Google App Engine
This is Rietveld 408576698