Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 551363002: Allow some runtime functions to accept Int32s instead of Smis. (Closed)

Created:
6 years, 3 months ago by Michael Starzinger
Modified:
6 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Allow some runtime functions to accept Int32s instead of Smis. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23796

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -240 lines) Patch
M src/runtime.cc View 1 8 chunks +21 lines, -12 lines 0 comments Download
D test/mjsunit/new-string-add.js View 1 chunk +0 lines, -197 lines 0 comments Download
D test/mjsunit/runtime-gen/apply.js View 1 chunk +0 lines, -9 lines 0 comments Download
D test/mjsunit/runtime-gen/newstring.js View 1 chunk +0 lines, -6 lines 0 comments Download
D test/mjsunit/runtime-gen/regexpexecrt.js View 1 chunk +0 lines, -8 lines 0 comments Download
D test/mjsunit/runtime-gen/truncatestring.js View 1 chunk +0 lines, -6 lines 0 comments Download
M tools/generate-runtime-tests.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
https://codereview.chromium.org/551363002/diff/1/test/mjsunit/new-string-add.js File test/mjsunit/new-string-add.js (left): https://codereview.chromium.org/551363002/diff/1/test/mjsunit/new-string-add.js#oldcode28 test/mjsunit/new-string-add.js:28: // Flags: --new-string-add Note that this test is an ...
6 years, 3 months ago (2014-09-09 11:22:54 UTC) #1
Benedikt Meurer
lgtm
6 years, 3 months ago (2014-09-09 11:52:48 UTC) #2
Michael Starzinger
6 years, 3 months ago (2014-09-09 12:12:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 23796 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698