Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 551343003: Oilpan: Replace blink_gc_plugin_dump_graph with a more general blink_gc_plugin_flags GYP variable. (Closed)

Created:
6 years, 3 months ago by zerny-chromium
Modified:
6 years, 3 months ago
Reviewers:
haraken, tkent
CC:
blink-reviews, oilpan-reviews
Project:
blink
Visibility:
Public.

Description

Oilpan: Replace blink_gc_plugin_dump_graph with a more general blink_gc_plugin_flags GYP variable. This allows developers to pass any combination of plugin flags without modifying the existing GYP setup. For example, GYP_DEFINES+="blink_gc_plugin_flags='dump-graph=1 warn-raw-ptr=1'" will enable both graph dumps and raw-pointer warnings. R=haraken@chromium.org BUG=334149 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181734

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M Source/config.gyp View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
zerny-chromium
6 years, 3 months ago (2014-09-09 10:27:24 UTC) #1
haraken
LGTM
6 years, 3 months ago (2014-09-09 10:28:13 UTC) #2
zerny-chromium
tkent@ could you do the owner review?
6 years, 3 months ago (2014-09-09 10:31:28 UTC) #4
zerny-chromium
Chrome side plugin change: https://codereview.chromium.org/551343002/
6 years, 3 months ago (2014-09-09 10:32:12 UTC) #5
tkent
lgtm
6 years, 3 months ago (2014-09-09 22:50:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/551343003/1
6 years, 3 months ago (2014-09-10 13:26:49 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 14:29:28 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181734

Powered by Google App Engine
This is Rietveld 408576698