tools/clang/scripts/blink_gc_plugin_flags.sh - Issue 551343002: Blink GC plugin: Add plugin flags for generating raw-pointer errors and unneeded-finalizer warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/scripts/blink_gc_plugin_flags.sh

Issue 551343002: Blink GC plugin: Add plugin flags for generating raw-pointer errors and unneeded-finalizer warnings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: presubmit Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/clang/scripts/blink_gc_plugin_flags.sh

diff --git a/tools/clang/scripts/blink_gc_plugin_flags.sh b/tools/clang/scripts/blink_gc_plugin_flags.sh

index 25c587294b076ea0940b384c73021707060a8864..eebb69be95bb2b56f2d747c61761f406d3306aca 100755

--- a/tools/clang/scripts/blink_gc_plugin_flags.sh

+++ b/tools/clang/scripts/blink_gc_plugin_flags.sh

@@ -19,11 +19,16 @@ $(grep LIBRARYNAME "$THIS_ABS_DIR"/../blink_gc_plugin/Makefile \

| cut -d ' ' -f 3)

FLAGS=""

+PREFIX="-Xclang -plugin-arg-blink-gc-plugin -Xclang"

for arg in "$@"; do

if [[ "$arg" = "enable-oilpan=1" ]]; then

- FLAGS="$FLAGS -Xclang -plugin-arg-blink-gc-plugin -Xclang enable-oilpan"

+ FLAGS="$FLAGS $PREFIX enable-oilpan"

elif [[ "$arg" = "dump-graph=1" ]]; then

- FLAGS="$FLAGS -Xclang -plugin-arg-blink-gc-plugin -Xclang dump-graph"

+ FLAGS="$FLAGS $PREFIX dump-graph"

+ elif [[ "$arg" = "warn-raw-ptr=1" ]]; then

+ FLAGS="$FLAGS $PREFIX warn-raw-ptr"

+ elif [[ "$arg" = "warn-unneeded-finalizer=1" ]]; then

+ FLAGS="$FLAGS $PREFIX warn-unneeded-finalizer"

done

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/class_does_not_require_finalization.txt ('k') | no next file » | no next file with comments »