Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: tools/clang/blink_gc_plugin/tests/class_does_not_require_finalization.cpp

Issue 551343002: Blink GC plugin: Add plugin flags for generating raw-pointer errors and unneeded-finalizer warnings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: presubmit Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/tests/class_does_not_require_finalization.cpp
diff --git a/tools/clang/blink_gc_plugin/tests/non_virtual_trace.cpp b/tools/clang/blink_gc_plugin/tests/class_does_not_require_finalization.cpp
similarity index 50%
copy from tools/clang/blink_gc_plugin/tests/non_virtual_trace.cpp
copy to tools/clang/blink_gc_plugin/tests/class_does_not_require_finalization.cpp
index 9f5771193c9481376459577261f16880f5e7d578..9c51eca0c1d13138bd5d549ac2f3150db57e59b1 100644
--- a/tools/clang/blink_gc_plugin/tests/non_virtual_trace.cpp
+++ b/tools/clang/blink_gc_plugin/tests/class_does_not_require_finalization.cpp
@@ -2,22 +2,21 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "non_virtual_trace.h"
+#include "class_does_not_require_finalization.h"
namespace blink {
-void A::trace(Visitor* visitor)
+void DoesNotNeedFinalizer::trace(Visitor* visitor)
{
}
-void C::trace(Visitor* visitor)
+DoesNotNeedFinalizer2::~DoesNotNeedFinalizer2()
{
- B::trace(visitor);
}
-void D::trace(Visitor* visitor)
+void DoesNotNeedFinalizer2::trace(Visitor* visitor)
{
- B::trace(visitor);
}
+
}

Powered by Google App Engine
This is Rietveld 408576698