Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 551333003: Added BASE_EXPORT to EnabledStateObserver class (Closed)

Created:
6 years, 3 months ago by xunjieli
Modified:
6 years, 3 months ago
Reviewers:
dsinclair, nduca
CC:
mmenke, chromium-reviews, wfh+watch_chromium.org, dsinclair+watch_chromium.org, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Added BASE_EXPORT to EnabledStateObserver class This CL adds a BASE_EXPORT to EnabledStateObserver class. This CL is a part of the effort to get NetLog data into tracing. Since EnabledStateObserver is not base exported, we would like it to be so that we can use it outside base. BUG=399701 Committed: https://crrev.com/3625753bba5b7097677c9922c71a6557e1772909 Cr-Commit-Position: refs/heads/master@{#293943}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M base/debug/trace_event_impl.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
xunjieli
Hi Nat and Dan, I have moved the BASE_EXPORT change out of CL(536503002) into this ...
6 years, 3 months ago (2014-09-09 13:44:07 UTC) #2
dsinclair
lgtm
6 years, 3 months ago (2014-09-09 13:46:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xunjieli@chromium.org/551333003/1
6 years, 3 months ago (2014-09-09 13:47:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as c7a868dace358049c94a35b08585cc2617a85789
6 years, 3 months ago (2014-09-09 15:40:39 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:53:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3625753bba5b7097677c9922c71a6557e1772909
Cr-Commit-Position: refs/heads/master@{#293943}

Powered by Google App Engine
This is Rietveld 408576698