Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 551333002: Fix WebCore.Scripts.ParserBlocking.TimeBetweenLoadedAndCompiled (Closed)

Created:
6 years, 3 months ago by marja
Modified:
6 years, 3 months ago
CC:
abarth-chromium, arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Project:
blink
Visibility:
Public.

Description

Fix WebCore.Scripts.ParserBlocking.TimeBetweenLoadedAndCompiled 1) The results were skewed by scripts from the same resource being ran several times (so we saw times > 10 s). 2) Script run time was included in the measurement, and it shouldn't be. WebCore.Scripts.Deferred.TimeBetweenLoadedAndCompiled is removed for now (to be fixed later, when it's really needed). Tracking whether a deferred script was already loaded when requested is more complicated. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181641

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -18 lines) Patch
M Source/bindings/core/v8/ScriptController.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/ScriptController.cpp View 5 chunks +8 lines, -5 lines 0 comments Download
M Source/core/dom/ScriptLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ScriptLoader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/parser/HTMLScriptRunner.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/html/parser/HTMLScriptRunner.cpp View 1 5 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
marja
jochen, ptal
6 years, 3 months ago (2014-09-09 09:16:28 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-09 09:33:27 UTC) #3
haraken
LGTM
6 years, 3 months ago (2014-09-09 09:41:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/551333002/20001
6 years, 3 months ago (2014-09-09 09:56:42 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/26188)
6 years, 3 months ago (2014-09-09 11:51:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/551333002/20001
6 years, 3 months ago (2014-09-09 12:08:13 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-09 13:00:52 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 181641

Powered by Google App Engine
This is Rietveld 408576698