Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 55133005: Remove EnableZygote API. (Closed)

Created:
7 years, 1 month ago by Jorge Lucangeli Obes
Modified:
7 years, 1 month ago
CC:
chromium-reviews, extensions-reviews_chromium.org, tzik, Lei Zhang, joi+watch-content_chromium.org, tommycli, darin-cc_chromium.org, Greg Billock, vandebo (ex-Chrome), chromium-apps-reviews_chromium.org, kinuko+watch
Visibility:
Public.

Description

Remove EnableZygote API. EnableZygote exposes an implementation detail. The utility process already has a DisableSandbox method, and a SetExposedDir method that we can use to disable the zygote. BUG=None TEST=browser_tests, launch Chrome and install an extension. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232906

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove unused |use_linux_zygote_| member variable. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -32 lines) Patch
M chrome/browser/component_updater/component_updater_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/management/management_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/updater/safe_manifest_parser.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/webstore_install_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/image_decoder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/local_discovery/service_discovery_host_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/safe_audio_video_checker.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/safe_itunes_pref_parser_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/safe_picasa_albums_indexer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_json_parser.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/web_resource/json_asynchronous_unpacker.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/utility_process_host_impl.h View 1 3 chunks +2 lines, -5 lines 0 comments Download
M content/browser/utility_process_host_impl.cc View 4 chunks +8 lines, -11 lines 0 comments Download
M content/public/browser/utility_process_host.h View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Jorge Lucangeli Obes
7 years, 1 month ago (2013-10-31 20:37:06 UTC) #1
jln (very slow on Chromium)
On 2013/10/31 20:37:06, Jorge Lucangeli Obes wrote: lgtm
7 years, 1 month ago (2013-10-31 21:24:47 UTC) #2
Jorge Lucangeli Obes
On 2013/10/31 21:24:47, jln wrote: > On 2013/10/31 20:37:06, Jorge Lucangeli Obes wrote: > > ...
7 years, 1 month ago (2013-10-31 22:46:39 UTC) #3
Lei Zhang
chrome/ lgtm with nit: https://codereview.chromium.org/55133005/diff/1/content/browser/utility_process_host_impl.h File content/browser/utility_process_host_impl.h (right): https://codereview.chromium.org/55133005/diff/1/content/browser/utility_process_host_impl.h#newcode79 content/browser/utility_process_host_impl.h:79: bool use_linux_zygote_; Remove?
7 years, 1 month ago (2013-11-01 18:39:08 UTC) #4
asargent_no_longer_on_chrome
lgtm
7 years, 1 month ago (2013-11-01 22:28:34 UTC) #5
Jorge Lucangeli Obes
https://codereview.chromium.org/55133005/diff/1/content/browser/utility_process_host_impl.h File content/browser/utility_process_host_impl.h (right): https://codereview.chromium.org/55133005/diff/1/content/browser/utility_process_host_impl.h#newcode79 content/browser/utility_process_host_impl.h:79: bool use_linux_zygote_; On 2013/11/01 18:39:09, Lei Zhang wrote: > ...
7 years, 1 month ago (2013-11-01 22:30:17 UTC) #6
Lei Zhang
lgtm++
7 years, 1 month ago (2013-11-01 22:39:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jorgelo@chromium.org/55133005/130001
7 years, 1 month ago (2013-11-01 22:57:13 UTC) #8
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=34066
7 years, 1 month ago (2013-11-01 23:35:26 UTC) #9
Jorge Lucangeli Obes
John, could you take a look for content/ OWNERS?
7 years, 1 month ago (2013-11-01 23:47:24 UTC) #10
Jorge Lucangeli Obes
On 2013/11/01 23:47:24, Jorge Lucangeli Obes wrote: > John, could you take a look for ...
7 years, 1 month ago (2013-11-04 18:15:47 UTC) #11
jam
On 2013/11/04 18:15:47, Jorge Lucangeli Obes wrote: > On 2013/11/01 23:47:24, Jorge Lucangeli Obes wrote: ...
7 years, 1 month ago (2013-11-04 20:10:48 UTC) #12
Jorge Lucangeli Obes
On 2013/11/04 20:10:48, jam wrote: > On 2013/11/04 18:15:47, Jorge Lucangeli Obes wrote: > > ...
7 years, 1 month ago (2013-11-04 20:59:46 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jorgelo@chromium.org/55133005/130001
7 years, 1 month ago (2013-11-04 22:48:39 UTC) #14
jam
On 2013/11/04 20:59:46, Jorge Lucangeli Obes wrote: > On 2013/11/04 20:10:48, jam wrote: > > ...
7 years, 1 month ago (2013-11-05 02:11:22 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jorgelo@chromium.org/55133005/130001
7 years, 1 month ago (2013-11-05 03:14:58 UTC) #16
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 04:36:53 UTC) #17
Message was sent while issue was closed.
Change committed as 232906

Powered by Google App Engine
This is Rietveld 408576698