Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 551323003: Fixed flakiness in PolicyTest.FileURLBlacklist. (Closed)

Created:
6 years, 3 months ago by Joao da Silva
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Re-enabled PolicyTest.FileURLBlacklist. This test flakes on the Mac. This CL adds additional logging to help diagnose the source of flakiness. BUG=339240 Committed: https://crrev.com/82405166f151d0d0be73d040aa5b77d309034aa0 Cr-Commit-Position: refs/heads/master@{#295956}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : enable test #

Patch Set 5 : assert_ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -26 lines) Patch
M chrome/browser/policy/policy_browsertest.cc View 1 2 3 4 9 chunks +21 lines, -26 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Joao da Silva
PTAL
6 years, 3 months ago (2014-09-22 11:49:14 UTC) #2
pneubeck (no reviews)
lgtm seems that this is to get more logging and doesn't fix the problem. Please ...
6 years, 3 months ago (2014-09-22 12:06:13 UTC) #3
Joao da Silva
All done, thanks for having a look.
6 years, 3 months ago (2014-09-22 12:12:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/551323003/80001
6 years, 3 months ago (2014-09-22 12:14:25 UTC) #6
commit-bot: I haz the power
Committed patchset #5 (id:80001) as 32f25a846c060e06d34b6f0fc14a7830eb6b0a36
6 years, 3 months ago (2014-09-22 12:49:43 UTC) #7
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/82405166f151d0d0be73d040aa5b77d309034aa0 Cr-Commit-Position: refs/heads/master@{#295956}
6 years, 3 months ago (2014-09-22 12:50:22 UTC) #8
jam
6 years, 2 months ago (2014-09-28 15:17:37 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/608153002/ by jam@chromium.org.

The reason for reverting is: It's causing lots of flakiness on trybots, now that
you added logging look at the past flakiness for more info:

http://chromium-try-flakes.appspot.com/search?q=PolicyTest.FileURLBlacklist.

Powered by Google App Engine
This is Rietveld 408576698