Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 551293002: Refactor PendingScript / HTMLScriptRunner. (Closed)

Created:
6 years, 3 months ago by marja
Modified:
6 years, 3 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-html_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Refactor PendingScript / HTMLScriptRunner. Goal: PendingScript should know how to watch for its resource to load, and upper layers (such as HTMLScriptRunner) should delegate the "how to watch for load" logic to PendingScript, instead of accessing its resource directly. In addition, a function to extract source code from PendingScript should be in PendingScript, not in HTMLScriptRunner. The refactoring is split off from https://codereview.chromium.org/368283002 (script streaming), but it makes sense as standalone too. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181627

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -44 lines) Patch
M Source/core/dom/PendingScript.h View 3 chunks +5 lines, -2 lines 0 comments Download
M Source/core/dom/PendingScript.cpp View 2 chunks +30 lines, -0 lines 0 comments Download
M Source/core/html/parser/HTMLScriptRunner.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/html/parser/HTMLScriptRunner.cpp View 6 chunks +6 lines, -38 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
marja
haraken, ptal. I think this refactoring would make sense as a standalone; wdyt?
6 years, 3 months ago (2014-09-09 07:44:29 UTC) #2
haraken
LGTM
6 years, 3 months ago (2014-09-09 07:50:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/551293002/1
6 years, 3 months ago (2014-09-09 08:05:10 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-09 09:24:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181627

Powered by Google App Engine
This is Rietveld 408576698