Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Issue 551253002: Web Animations: Zero time of the document timeline should correspond with navigationStart (Closed)

Created:
6 years, 3 months ago by dstockwell
Modified:
6 years, 3 months ago
Reviewers:
Timothy Loh
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, Eric Willigers, Mike Lawther (Google), rjwright, shans, Steve Block
Project:
blink
Visibility:
Public.

Description

Web Animations: Zero time of the document timeline should correspond with navigationStart See: http://dev.w3.org/fxtf/web-animations/#dfn-zero-time Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181608

Patch Set 1 #

Patch Set 2 : Specify time when resetting animation clock in tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -5 lines) Patch
M LayoutTests/web-animations-api/timeline-time.html View 1 chunk +11 lines, -0 lines 0 comments Download
M Source/core/animation/AnimationClock.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimationClock.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/AnimationTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimationTimeline.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/animation/AnimationTimeline.cpp View 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dstockwell
6 years, 3 months ago (2014-09-09 03:37:40 UTC) #2
dstockwell
ptal, fixed the failing unit tests.
6 years, 3 months ago (2014-09-09 04:30:27 UTC) #3
Timothy Loh
On 2014/09/09 04:30:27, dstockwell wrote: > ptal, fixed the failing unit tests. ok, lgtm
6 years, 3 months ago (2014-09-09 04:36:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/551253002/20001
6 years, 3 months ago (2014-09-09 04:39:06 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-09 05:20:35 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 181608

Powered by Google App Engine
This is Rietveld 408576698