Requesting background permission only when user is opted in to GN

Requesting background permission only when user is opted in to GN.

BUG=164227
TEST=Opt the user out and in, and check that next poll sets/unsets background permission correspondingly.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232464

[robliao, 2013-10-31 18:29:40]

https://codereview.chromium.org/55123002/diff/1/chrome/browser/resources/goog...
File chrome/browser/resources/google_now/background.js (right):

https://codereview.chromium.org/55123002/diff/1/chrome/browser/resources/goog...
chrome/browser/resources/google_now/background.js:488: onStateChange();
Comment that if we make it here, Google Now was previously enabled.

https://codereview.chromium.org/55123002/diff/1/chrome/browser/resources/goog...
chrome/browser/resources/google_now/background.js:608: onStateChange();
Same here. If we're here, Google Now was previously disabled.

https://codereview.chromium.org/55123002/diff/1/chrome/browser/resources/goog...
chrome/browser/resources/google_now/background.js:932:
chrome.storage.local.set({googleNowEnabled: false});
Semantically, this isn't necessarily correct if the user simply unchecks us from
the notification center.

[vadimt, 2013-10-31 20:14:08]

Comments + rebase.

https://codereview.chromium.org/55123002/diff/1/chrome/browser/resources/goog...
File chrome/browser/resources/google_now/background.js (right):

https://codereview.chromium.org/55123002/diff/1/chrome/browser/resources/goog...
chrome/browser/resources/google_now/background.js:488: onStateChange();
On 2013/10/31 18:29:41, Robert Liao wrote:
> Comment that if we make it here, Google Now was previously enabled.

Done.

https://codereview.chromium.org/55123002/diff/1/chrome/browser/resources/goog...
chrome/browser/resources/google_now/background.js:608: onStateChange();
On 2013/10/31 18:29:41, Robert Liao wrote:
> Same here. If we're here, Google Now was previously disabled.

Done.

https://codereview.chromium.org/55123002/diff/1/chrome/browser/resources/goog...
chrome/browser/resources/google_now/background.js:932:
chrome.storage.local.set({googleNowEnabled: false});
On 2013/10/31 18:29:41, Robert Liao wrote:
> Semantically, this isn't necessarily correct if the user simply unchecks us
from
> the notification center.

When the user checks us again in NC, we should start with sending "IS OPTED IN"
request. Without this, we'd simply start polling.

[rgustafson, 2013-10-31 22:48:22]

lgtm

[robliao, 2013-10-31 23:05:00]

https://codereview.chromium.org/55123002/diff/1/chrome/browser/resources/goog...
File chrome/browser/resources/google_now/background.js (right):

https://codereview.chromium.org/55123002/diff/1/chrome/browser/resources/goog...
chrome/browser/resources/google_now/background.js:932:
chrome.storage.local.set({googleNowEnabled: false});
This would be an excellent place for a comment.
On 2013/10/31 20:14:08, vadimt wrote:
> On 2013/10/31 18:29:41, Robert Liao wrote:
> > Semantically, this isn't necessarily correct if the user simply unchecks us
> from
> > the notification center.
> 
> When the user checks us again in NC, we should start with sending "IS OPTED
IN"
> request. Without this, we'd simply start polling.

[vadimt, 2013-11-01 00:49:47]

https://codereview.chromium.org/55123002/diff/1/chrome/browser/resources/goog...
File chrome/browser/resources/google_now/background.js (right):

https://codereview.chromium.org/55123002/diff/1/chrome/browser/resources/goog...
chrome/browser/resources/google_now/background.js:932:
chrome.storage.local.set({googleNowEnabled: false});
On 2013/10/31 23:05:01, Robert Liao wrote:
> This would be an excellent place for a comment.
> On 2013/10/31 20:14:08, vadimt wrote:
> > On 2013/10/31 18:29:41, Robert Liao wrote:
> > > Semantically, this isn't necessarily correct if the user simply unchecks
us
> > from
> > > the notification center.
> > 
> > When the user checks us again in NC, we should start with sending "IS OPTED
> IN"
> > request. Without this, we'd simply start polling.
> 

Done.

[robliao, 2013-11-01 00:52:45]

lgtm

[commit-bot: I haz the power, 2013-11-01 14:07:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vadimt@chromium.org/55123002/140001

[commit-bot: I haz the power, 2013-11-01 15:28:47]

Retried try job too often on linux_chromeos for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-11-01 15:38:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vadimt@chromium.org/55123002/140001

[commit-bot: I haz the power, 2013-11-01 16:58:59]

Retried try job too often on linux_chromeos for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-11-01 17:16:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vadimt@chromium.org/55123002/140001

[skare_, 2013-11-01 18:00:30]

lgtm

[commit-bot: I haz the power, 2013-11-01 19:10:12]

Retried try job too often on linux_chromeos for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-11-01 19:37:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vadimt@chromium.org/55123002/140001

[commit-bot: I haz the power, 2013-11-01 20:40:29]

Change committed as 232464