src/v8.h - Issue 551228: Allow building V8 with both DEBUG and NDEBUG defined at ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/v8.h

Issue 551228: Allow building V8 with both DEBUG and NDEBUG defined at ... (Closed) Base URL: http://v8.googlecode.com/svn/branches/experimental/issue555/

Patch Set: Created 10 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/v8.h

===================================================================

--- src/v8.h (revision 3745)

+++ src/v8.h (working copy)

@@ -32,18 +32,15 @@

#ifndef V8_V8_H_

#define V8_V8_H_

-#if defined(GOOGLE3)

-// Google3 special flag handling.

#if defined(DEBUG) && defined(NDEBUG)

-// If both are defined in Google3, then we are building an optimized v8 with

+// If both are defined then we are building an optimized v8 with

// assertions enabled.

#undef NDEBUG

#elif !defined(DEBUG) && !defined(NDEBUG)

-// If neither is defined in Google3, then we are building a debug v8. Mark it

-// as such.

+// If neither is defined then we default to building a debug v8. Mark

+// it as such.

#define DEBUG

#endif

-#endif // defined(GOOGLE3)

// V8 only uses DEBUG, but included external files

// may use NDEBUG - make sure they are consistent.

« no previous file with comments | « no previous file | no next file » | no next file with comments »