Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 551228: Allow building V8 with both DEBUG and NDEBUG defined at ... (Closed)

Created:
10 years, 10 months ago by Kasper Lund
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Allow building V8 with both DEBUG and NDEBUG defined at the same time (used from the Gyp-based build) on the experimental issue 555 branch. This is used to build an optimized version of V8 that runs with assertions enabled. Committed: http://code.google.com/p/v8/source/detail?r=3751

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M src/v8.h View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kasper Lund
10 years, 10 months ago (2010-02-01 10:27:05 UTC) #1
Kasper Lund
TBR'ed.
10 years, 10 months ago (2010-02-01 10:28:40 UTC) #2
Mads Ager (chromium)
10 years, 10 months ago (2010-02-01 10:54:57 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698