Binary size tool, handle symbols with no path better.

Binary size tool, handle symbols with no path better.

If symbols with the same name appeared in the same "file" (as in
'unknown file') then they collided and only the last such symbol was
remembered. This happened for me with string symbols where all
.L.str21 were in the ?? file.

Store a list of symbol sizes per symbol and file. If there are more
than one symbol size per symbol and file, compare them differently to
see what might have happened.

A bit hard to read code. I hope it won't have to be changed.

BUG=412335
R=andrewhayden@chromium.org

Committed: https://crrev.com/352f1537f3774bb29bb084ad95e30bf52930917a
Cr-Commit-Position: refs/heads/master@{#295033}

[Daniel Bratell, 2014-09-12 12:45:10]

Example output from a change I did in another patch, where I did change a lot of
strings (which made me discover this bug):

Total change: -2215 bytes
=========================
  23 added, totalling +556 bytes across 1 sources
  22 removed, totalling -575 bytes across 1 sources
  1 shrunk, for a net change of -2196 bytes (4808 bytes before, 2612 bytes
after) across 1 sources
  267963 unchanged, totalling 50319583 bytes
Source stats:
  12202 sources encountered.
  0 completely new.
  0 removed completely.
  2 partially changed.
  12200 completely unchanged.
Per-source Analysis:

------------------------------------------
 -19 - Source: ?? - (gained 556, lost 575)
------------------------------------------
  New symbols:
        +85: .L.str104 type=r, size=85 bytes
        +70: .L.str119 type=r, size=70 bytes
        +51: .L.str109 type=r, size=51 bytes
        +40: .L.str100 type=r, size=40 bytes
        +31: .L.str102 type=r, size=31 bytes
        +31: .L.str97 type=r, size=31 bytes
        +30: .L.str108 type=r, size=30 bytes
        +29: .L.str101 type=r, size=29 bytes
        +29: .L.str105 type=r, size=29 bytes
        +26: .L.str99 type=r, size=26 bytes
        +25: .L.str103 type=r, size=25 bytes
        +24: .L.str120 type=r, size=24 bytes
        +20: .L.str114 type=r, size=20 bytes
        +15: .L.str111 type=r, size=15 bytes
        +12: .L.str112 type=r, size=12 bytes
         +8: .L.str118 type=r, size=8 bytes
         +6: .L.str117 type=r, size=6 bytes
         +5: .L.str113 type=r, size=5 bytes
         +4: .L.str121 type=r, size=4 bytes
         +4: .L.str107 type=r, size=4 bytes
         +4: .L.str98 type=r, size=4 bytes
         +4: .L.str110 type=r, size=4 bytes
         +3: .L.str106 type=r, size=3 bytes
  Removed symbols:
         -3: .L.str99 type=r, size=3 bytes
         -4: .L.str120 type=r, size=4 bytes
         -4: .L.str103 type=r, size=4 bytes
         -4: .L.str100 type=r, size=4 bytes
         -5: .L.str106 type=r, size=5 bytes
         -6: .L.str116 type=r, size=6 bytes
         -8: .L.str117 type=r, size=8 bytes
        -12: .L.str105 type=r, size=12 bytes
        -15: .L.str104 type=r, size=15 bytes
        -20: .L.str107 type=r, size=20 bytes
        -24: .L.str119 type=r, size=24 bytes
        -28: .L.str113 type=r, size=28 bytes
        -29: .L.str109 type=r, size=29 bytes
        -29: .L.str98 type=r, size=29 bytes
        -30: .L.str101 type=r, size=30 bytes
        -31: .L.str108 type=r, size=31 bytes
        -34: .L.str112 type=r, size=34 bytes
        -36: .L.str111 type=r, size=36 bytes
        -47: .L.str110 type=r, size=47 bytes
        -51: .L.str102 type=r, size=51 bytes
        -70: .L.str118 type=r, size=70 bytes
        -85: .L.str97 type=r, size=85 bytes

-----------------------------------------------------------------------------------------------------------------------
 -2196 - Source:
/home/bratell/src/chromium/src/third_party/WebKit/Source/core/dom/Document.cpp -
(gained 0, lost 2196)
-----------------------------------------------------------------------------------------------------------------------
  Shrunk symbols:
      -2196: blink::Document::parseQualifiedName(WTF::AtomicString const&,
WTF::AtomicString&, WTF::AtomicString&, blink::ExceptionState&) type=t, (was
4808 bytes, now 2612 bytes)

[Andrew Hayden (chromium.org), 2014-09-15 08:40:00]

On 2014/09/12 12:45:10, Daniel Bratell wrote:
> Example output from a change I did in another patch, where I did change a lot
of
> strings (which made me discover this bug):
> 
> Total change: -2215 bytes
> =========================
>   23 added, totalling +556 bytes across 1 sources
>   22 removed, totalling -575 bytes across 1 sources
>   1 shrunk, for a net change of -2196 bytes (4808 bytes before, 2612 bytes
> after) across 1 sources
>   267963 unchanged, totalling 50319583 bytes
> Source stats:
>   12202 sources encountered.
>   0 completely new.
>   0 removed completely.
>   2 partially changed.
>   12200 completely unchanged.
> Per-source Analysis:
> 
> ------------------------------------------
>  -19 - Source: ?? - (gained 556, lost 575)
> ------------------------------------------
>   New symbols:
>         +85: .L.str104 type=r, size=85 bytes
>         +70: .L.str119 type=r, size=70 bytes
>         +51: .L.str109 type=r, size=51 bytes
>         +40: .L.str100 type=r, size=40 bytes
>         +31: .L.str102 type=r, size=31 bytes
>         +31: .L.str97 type=r, size=31 bytes
>         +30: .L.str108 type=r, size=30 bytes
>         +29: .L.str101 type=r, size=29 bytes
>         +29: .L.str105 type=r, size=29 bytes
>         +26: .L.str99 type=r, size=26 bytes
>         +25: .L.str103 type=r, size=25 bytes
>         +24: .L.str120 type=r, size=24 bytes
>         +20: .L.str114 type=r, size=20 bytes
>         +15: .L.str111 type=r, size=15 bytes
>         +12: .L.str112 type=r, size=12 bytes
>          +8: .L.str118 type=r, size=8 bytes
>          +6: .L.str117 type=r, size=6 bytes
>          +5: .L.str113 type=r, size=5 bytes
>          +4: .L.str121 type=r, size=4 bytes
>          +4: .L.str107 type=r, size=4 bytes
>          +4: .L.str98 type=r, size=4 bytes
>          +4: .L.str110 type=r, size=4 bytes
>          +3: .L.str106 type=r, size=3 bytes
>   Removed symbols:
>          -3: .L.str99 type=r, size=3 bytes
>          -4: .L.str120 type=r, size=4 bytes
>          -4: .L.str103 type=r, size=4 bytes
>          -4: .L.str100 type=r, size=4 bytes
>          -5: .L.str106 type=r, size=5 bytes
>          -6: .L.str116 type=r, size=6 bytes
>          -8: .L.str117 type=r, size=8 bytes
>         -12: .L.str105 type=r, size=12 bytes
>         -15: .L.str104 type=r, size=15 bytes
>         -20: .L.str107 type=r, size=20 bytes
>         -24: .L.str119 type=r, size=24 bytes
>         -28: .L.str113 type=r, size=28 bytes
>         -29: .L.str109 type=r, size=29 bytes
>         -29: .L.str98 type=r, size=29 bytes
>         -30: .L.str101 type=r, size=30 bytes
>         -31: .L.str108 type=r, size=31 bytes
>         -34: .L.str112 type=r, size=34 bytes
>         -36: .L.str111 type=r, size=36 bytes
>         -47: .L.str110 type=r, size=47 bytes
>         -51: .L.str102 type=r, size=51 bytes
>         -70: .L.str118 type=r, size=70 bytes
>         -85: .L.str97 type=r, size=85 bytes
> 
>
-----------------------------------------------------------------------------------------------------------------------
>  -2196 - Source:
> /home/bratell/src/chromium/src/third_party/WebKit/Source/core/dom/Document.cpp
-
> (gained 0, lost 2196)
>
-----------------------------------------------------------------------------------------------------------------------
>   Shrunk symbols:
>       -2196: blink::Document::parseQualifiedName(WTF::AtomicString const&,
> WTF::AtomicString&, WTF::AtomicString&, blink::ExceptionState&) type=t, (was
> 4808 bytes, now 2612 bytes)

This seems reasonable to me. Thanks for the additional functionality!

[Andrew Hayden (chromium.org), 2014-09-15 08:40:10]

Er, LGTM :)

[Daniel Bratell, 2014-09-16 08:14:48]

The CQ bit was checked by bratell@opera.com

[commit-bot: I haz the power, 2014-09-16 08:14:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/551203004/1

[commit-bot: I haz the power, 2014-09-16 09:11:01]

Committed patchset #1 (id:1) as 1890d51eebdacea9364b63c559d0473602be958a

[commit-bot: I haz the power, 2014-09-16 09:12:10]

Patchset 1 (id:??) landed as
https://crrev.com/352f1537f3774bb29bb084ad95e30bf52930917a
Cr-Commit-Position: refs/heads/master@{#295033}