[TextBlob] Fix LCD text handling.

[TextBlob] Fix LCD text handling.

The LCD bit is captured in run paints at blob build time, so any
adjustments should be performed at that point. Also, text encoding is
handled similarly, and we don't need to set it on draw paints.

R=jbroman@chromium.org,reed@chromium.org,eae@chromium.org
BUG=412445
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181757

[f(malita), 2014-09-10 17:03:55]

fmalita@chromium.org changed reviewers:
+ reed@google.com
- reed@chromium.org

[jbroman, 2014-09-10 17:09:40]

LGTM, though I hope we can soon get GraphicsContext back out of buildTextBlob.

https://codereview.chromium.org/551183005/diff/1/Source/platform/fonts/harfbu...
File Source/platform/fonts/harfbuzz/FontHarfBuzz.cpp (right):

https://codereview.chromium.org/551183005/diff/1/Source/platform/fonts/harfbu...
Source/platform/fonts/harfbuzz/FontHarfBuzz.cpp:324:
context.adjustTextRenderMode(&paint);
When can these properties of the GraphicsContext change? The built text blob may
be cached in the future.

I guess we will ultimately be able to remove this after reed's changes?

[f(malita), 2014-09-10 17:18:24]

On 2014/09/10 17:09:40, jbroman wrote:
> LGTM, though I hope we can soon get GraphicsContext back out of buildTextBlob.
> 
>
https://codereview.chromium.org/551183005/diff/1/Source/platform/fonts/harfbu...
> File Source/platform/fonts/harfbuzz/FontHarfBuzz.cpp (right):
> 
>
https://codereview.chromium.org/551183005/diff/1/Source/platform/fonts/harfbu...
> Source/platform/fonts/harfbuzz/FontHarfBuzz.cpp:324:
> context.adjustTextRenderMode(&paint);
> When can these properties of the GraphicsContext change? The built text blob
may
> be cached in the future.

I'm not sure when the backing can change LCD-ness, but agree that caching seems
frail given the current state. Luckily Mike has a plan and this should go away
soon :)

> I guess we will ultimately be able to remove this after reed's changes?

Yes, after reed's change we should be able to drop the adjustment and remove GC
from buildTextBlob.

[reed1, 2014-09-10 17:27:01]

could we just pass

, bool couldUseLCD

as the new parameter, instead of the entire context?

just wondering. sgtm

[eae, 2014-09-10 18:01:44]

LGTM

[f(malita), 2014-09-10 18:11:35]

On 2014/09/10 17:27:01, reed1 wrote:
> could we just pass
> 
> , bool couldUseLCD
> 
> as the new parameter, instead of the entire context?

I was a bit wary of making assumptions about what adjustTextRenderMode() is
doing, but since this is a temporary fix I guess it would be OK. Done.

[f(malita), 2014-09-10 19:06:22]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2014-09-10 19:07:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fmalita@chromium.org/551183005/40001

[commit-bot: I haz the power, 2014-09-10 19:17:03]

Committed patchset #3 (id:40001) as 181757