Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 551181: Load bundle resources when loading bundles on the Mac (Closed)

Created:
10 years, 11 months ago by stuartmorgan
Modified:
9 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Load bundle resources when loading bundles on the Mac BUG=32208 TEST=Right-click on a QuickTime movie; a context menu should come up. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37408

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M base/native_library.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/native_library_mac.mm View 1 chunk +6 lines, -2 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
stuartmorgan
10 years, 11 months ago (2010-01-27 23:00:08 UTC) #1
Avi (use Gerrit)
http://codereview.chromium.org/551181/diff/1/3 File base/native_library_mac.mm (right): http://codereview.chromium.org/551181/diff/1/3#newcode51 base/native_library_mac.mm:51: library->bundle_resource_ref); What if there was no resource map and ...
10 years, 11 months ago (2010-01-28 14:46:47 UTC) #2
stuartmorgan
http://codereview.chromium.org/551181/diff/1/3 File base/native_library_mac.mm (right): http://codereview.chromium.org/551181/diff/1/3#newcode51 base/native_library_mac.mm:51: library->bundle_resource_ref); On 2010/01/28 14:46:47, Avi wrote: > What if ...
10 years, 11 months ago (2010-01-28 15:24:37 UTC) #3
Avi (use Gerrit)
10 years, 11 months ago (2010-01-28 15:31:09 UTC) #4
Huh. LG then.

Powered by Google App Engine
This is Rietveld 408576698