Load bundle resources when loading bundles on the Mac

Load bundle resources when loading bundles on the Mac

BUG=32208
TEST=Right-click on a QuickTime movie; a context menu should come up.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37408

[Avi (use Gerrit), 2010-01-28 14:46:47]

http://codereview.chromium.org/551181/diff/1/3
File base/native_library_mac.mm (right):

http://codereview.chromium.org/551181/diff/1/3#newcode51
base/native_library_mac.mm:51: library->bundle_resource_ref);
What if there was no resource map and the open call returned -1; is it safe to
call close with the -1?

[stuartmorgan, 2010-01-28 15:24:37]

http://codereview.chromium.org/551181/diff/1/3
File base/native_library_mac.mm (right):

http://codereview.chromium.org/551181/diff/1/3#newcode51
base/native_library_mac.mm:51: library->bundle_resource_ref);
On 2010/01/28 14:46:47, Avi wrote:
> What if there was no resource map and the open call returned -1; is it safe to
> call close with the -1?

The docs say nothing about returning -1 (or anything else) on failure, and
neither the WebKit code nor our own plugin info reading code does any kind of
check.

[Avi (use Gerrit), 2010-01-28 15:31:09]

Huh. LG then.