Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Unified Diff: remoting/protocol/channel_factory.h

Issue 551173004: Move PseudoTCP and channel auth out of LibjingleTransportFactory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@clean_dgrams
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/protocol/channel_factory.h
diff --git a/remoting/protocol/channel_factory.h b/remoting/protocol/channel_factory.h
index 31bf3ec9df205cd5ebcac5f13eaf183ff50ef8f4..b4fe1f1ce467d577f58f07ea6fff2accc19da6c0 100644
--- a/remoting/protocol/channel_factory.h
+++ b/remoting/protocol/channel_factory.h
@@ -26,13 +26,12 @@ class ChannelFactory : public base::NonThreadSafe {
ChannelFactory() {}
- // Creates new channels for this connection. The specified callback is called
- // when then new channel is created and connected. The callback is called with
- // NULL if connection failed for any reason. Callback may be called
- // synchronously, before the call returns. All channels must be destroyed
- // before the factory is destroyed and CancelChannelCreation() must be called
- // to cancel creation of channels for which the |callback| hasn't been called
- // yet.
+ // Creates new channels and calls the |callback| when then new channel is
+ // created and connected. The |callback| is called with NULL if connection
+ // failed for any reason. Callback may be called synchronously, before the
+ // call returns. All channels must be destroyed before the factory is
+ // destroyed and CancelChannelCreation() must be called to cancel creation of
+ // channels for which the |callback| hasn't been called yet.
Wez 2014/09/10 02:29:26 nit: All channels must be destroyed, and Cancel...
Sergey Ulanov 2014/09/10 21:50:58 Done.
virtual void CreateChannel(const std::string& name,
const ChannelCreatedCallback& callback) = 0;

Powered by Google App Engine
This is Rietveld 408576698