Move PseudoTCP and channel auth out of LibjingleTransportFactory.

remoting/protocol/fake_authenticator.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/protocol/fake_authenticator.h"
 
 #include "base/message_loop/message_loop.h"
 #include "base/strings/string_number_conversions.h"
 #include "net/base/io_buffer.h"
+#include "net/base/net_errors.h"
 #include "net/socket/stream_socket.h"
 #include "remoting/base/constants.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/webrtc/libjingle/xmllite/xmlelement.h"
 
 namespace remoting {
 namespace protocol {
 
 FakeChannelAuthenticator::FakeChannelAuthenticator(bool accept, bool async)
     : result_(accept ? net::OK : net::ERR_FAILED),
       async_(async),
       did_read_bytes_(false),
       did_write_bytes_(false),
       weak_factory_(this) {
 }
 
 FakeChannelAuthenticator::~FakeChannelAuthenticator() {
 }
 
 void FakeChannelAuthenticator::SecureAndAuthenticate(
     scoped_ptr<net::StreamSocket> socket,
     const DoneCallback& done_callback) {
   socket_ = socket.Pass();
 
   if (async_) {
     done_callback_ = done_callback;
 
-    scoped_refptr<net::IOBuffer> write_buf = new net::IOBuffer(1);
-    write_buf->data()[0] = 0;
-    int result =
-        socket_->Write(write_buf.get(),
-                       1,
-                       base::Bind(&FakeChannelAuthenticator::OnAuthBytesWritten,
-                                  weak_factory_.GetWeakPtr()));
-    if (result != net::ERR_IO_PENDING) {
-      // This will not call the callback because |did_read_bytes_| is
-      // still set to false.
-      OnAuthBytesWritten(result);
+    if (result_ != net::OK) {
+      // Don't write anything if we are going to reject auth to make test
+      // ordering deterministic.
+      did_write_bytes_ = true;
+    } else {
+      scoped_refptr<net::IOBuffer> write_buf = new net::IOBuffer(1);
+      write_buf->data()[0] = 0;
+      int result = socket_->Write(
+          write_buf.get(), 1,
+          base::Bind(&FakeChannelAuthenticator::OnAuthBytesWritten,
+                     weak_factory_.GetWeakPtr()));
+      if (result != net::ERR_IO_PENDING) {
+        // This will not call the callback because |did_read_bytes_| is
+        // still set to false.
+        OnAuthBytesWritten(result);
+      }
     }
 
     scoped_refptr<net::IOBuffer> read_buf = new net::IOBuffer(1);
-    result =
-        socket_->Read(read_buf.get(),
-                      1,
+    int result =
+        socket_->Read(read_buf.get(), 1,
                       base::Bind(&FakeChannelAuthenticator::OnAuthBytesRead,
                                  weak_factory_.GetWeakPtr()));
     if (result != net::ERR_IO_PENDING)
       OnAuthBytesRead(result);
   } else {
-    if (result_ != net::OK)
-      socket_.reset();
-    done_callback.Run(result_, socket_.Pass());
+    CallDoneCallback();
   }
 }
 
 void FakeChannelAuthenticator::OnAuthBytesWritten(int result) {
   EXPECT_EQ(1, result);
   EXPECT_FALSE(did_write_bytes_);
   did_write_bytes_ = true;
   if (did_read_bytes_)
-    done_callback_.Run(result_, socket_.Pass());
+    CallDoneCallback();
 }
 
 void FakeChannelAuthenticator::OnAuthBytesRead(int result) {
   EXPECT_EQ(1, result);
   EXPECT_FALSE(did_read_bytes_);
   did_read_bytes_ = true;
   if (did_write_bytes_)
-    done_callback_.Run(result_, socket_.Pass());
+    CallDoneCallback();
+}
+
+void FakeChannelAuthenticator::CallDoneCallback() {
+  DoneCallback callback = done_callback_;
+  done_callback_.Reset();
+  if (result_ != net::OK)
+    socket_.reset();
+  callback.Run(result_, socket_.Pass());
 }
 
 FakeAuthenticator::FakeAuthenticator(
     Type type, int round_trips, Action action, bool async)
     : type_(type),
       round_trips_(round_trips),
       action_(action),
       async_(async),
       messages_(0),
       messages_till_started_(0) {
@@ skipping 90 matching lines @@
   FakeAuthenticator* authenticator = new FakeAuthenticator(
       FakeAuthenticator::HOST, round_trips_, action_, async_);
   authenticator->set_messages_till_started(messages_till_started_);
 
   scoped_ptr<Authenticator> result(authenticator);
   return result.Pass();
 }
 
 }  // namespace protocol
 }  // namespace remoting