Move PseudoTCP and channel auth out of LibjingleTransportFactory.

remoting/protocol/ssl_hmac_channel_authenticator_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/protocol/ssl_hmac_channel_authenticator.h"
 
 #include "base/base64.h"
 #include "base/bind.h"
 #include "base/file_util.h"
 #include "base/files/file_path.h"
@@ skipping 93 matching lines @@
     // called.
     base::Timer shutdown_timer(false, false);
     shutdown_timer.Start(FROM_HERE,
                          TestTimeouts::action_timeout(),
                          base::MessageLoop::QuitClosure());
     message_loop_.Run();
   }
 
   void OnHostConnected(net::Error error,
                        scoped_ptr<net::StreamSocket> socket) {
+    host_auth_.reset();

[Wez, 2014/09/10 02:29:27]

Why's this change required?

[Sergey Ulanov, 2014/09/10 21:50:59]

Previously SslHmacChannelAuthenticator wasn't calling the callback properly
which would lead to crash when it's deleted when the callback is called. This
change increases coverage for this case, but wouldn't catch the bug we had
before. Updated this test now so it crashes without the fix in
ssl_hmac_channel_authenticator.cc .

[Wez, 2014/09/10 22:19:42]

Acknowledged.

     host_callback_.OnDone(error, socket.get());
     host_socket_ = socket.Pass();
   }
 
   void OnClientConnected(net::Error error,
                          scoped_ptr<net::StreamSocket> socket) {
+    client_auth_.reset();
     client_callback_.OnDone(error, socket.get());
     client_socket_ = socket.Pass();
   }
 
   base::MessageLoop message_loop_;
 
   scoped_refptr<RsaKeyPair> key_pair_;
   std::string host_cert_;
   scoped_ptr<FakeSocket> client_fake_socket_;
   scoped_ptr<FakeSocket> host_fake_socket_;
@@ skipping 34 matching lines @@
   host_auth_ = SslHmacChannelAuthenticator::CreateForHost(
       host_cert_, key_pair_, kTestSharedSecret);
 
   RunChannelAuth(true);
 
   ASSERT_TRUE(host_socket_.get() == NULL);
 }
 
 }  // namespace protocol
 }  // namespace remoting