Move PseudoTCP and channel auth out of LibjingleTransportFactory.

remoting/protocol/ssl_hmac_channel_authenticator.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/protocol/ssl_hmac_channel_authenticator.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "crypto/secure_util.h"
 #include "net/base/host_port_pair.h"
@@ skipping 261 matching lines @@
 
   return crypto::SecureMemEqual(received_auth_bytes.data(),
                                 &(auth_bytes[0]), kAuthDigestLength);
 }
 
 void SslHmacChannelAuthenticator::CheckDone(bool* callback_called) {
   if (auth_write_buf_.get() == NULL && auth_read_buf_.get() == NULL) {
     DCHECK(socket_.get() != NULL);
     if (callback_called)
       *callback_called = true;
-    done_callback_.Run(net::OK, socket_.PassAs<net::StreamSocket>());
+
+    NotifyResult(net::OK, socket_.PassAs<net::StreamSocket>());
   }
 }
 
 void SslHmacChannelAuthenticator::NotifyError(int error) {
-  done_callback_.Run(static_cast<net::Error>(error),
-                     scoped_ptr<net::StreamSocket>());
+  NotifyResult(static_cast<net::Error>(error), scoped_ptr<net::StreamSocket>());

[Wez, 2014/09/10 02:29:27]

This has undefined and potentially scary behaviour if |error| is not a valid
enum value; consider using int in NotifyResult as well?

[Sergey Ulanov, 2014/09/10 21:50:59]

We will still need to convert int to net::Error because most net APIs return
int. It's better to use int everywhere for |error| - updated
ChannelAuthenticator interface now.

+}
+
+void SslHmacChannelAuthenticator::NotifyResult(
+    net::Error error,
+    scoped_ptr<net::StreamSocket> socket) {
+  DoneCallback callback = done_callback_;
+  done_callback_.Reset();
+  callback.Run(error, socket.Pass());
 }
 
 }  // namespace protocol
 }  // namespace remoting