Move PseudoTCP and channel auth out of LibjingleTransportFactory.

remoting/protocol/channel_authenticator.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_PROTOCOL_CHANNEL_AUTHENTICATOR_H_
 #define REMOTING_PROTOCOL_CHANNEL_AUTHENTICATOR_H_
 
 #include <string>
 
 #include "base/callback_forward.h"
 #include "net/base/net_errors.h"
 
 namespace net {
 class StreamSocket;
 }  // namespace net
 
 namespace remoting {
 namespace protocol {
 
 // Interface for channel authentications that perform channel-level
 // authentication. Depending on implementation channel authenticators
 // may also establish SSL connection. Each instance of this interface
 // should be used only once for one channel.
 class ChannelAuthenticator {
  public:
+  // Callback to be called when authentication is finished. It can delete
+  // calling authenticator.

[Wez, 2014/09/10 02:29:26]

Suggest moving this comment to the SecureAndAuthenticate API

[Sergey Ulanov, 2014/09/10 21:50:58]

Done.

   typedef base::Callback<void(net::Error error, scoped_ptr<net::StreamSocket>)>
       DoneCallback;
 
   virtual ~ChannelAuthenticator() {}
 
   // Start authentication of the given |socket|. |done_callback| is
   // called when authentication is finished. Callback may be invoked
   // before this method returns.

[Wez, 2014/09/10 02:29:26]

e.g. .. method returns, and may delete the calling authenticator.

[Sergey Ulanov, 2014/09/10 21:50:58]

Done.

   virtual void SecureAndAuthenticate(
       scoped_ptr<net::StreamSocket> socket,
       const DoneCallback& done_callback) = 0;
 };
 
 }  // namespace protocol
 }  // namespace remoting
 
 #endif  // REMOTING_PROTOCOL_CHANNEL_AUTHENTICATOR_H_