[GCM] Extracting Delayed Task Controller from GCMDesktopDriver

[GCM] Extracting Delayed Task Controller from GCMDesktopDriver

* Extracting DelayedTaskController from GCMDesktopDriver
* Renaming it to GCMDelayedTaskController
* Adding tests for GCMDelayedTaskController

BUG=374969
R=jianli@chromium.org

Committed: https://crrev.com/05d507c5ff8d67311e264c2ee9c9edc4729346b1
Cr-Commit-Position: refs/heads/master@{#294185}

[fgorski, 2014-09-08 21:51:02]

Jian, PTAL, when you find some time.

[jianli, 2014-09-09 19:53:18]

lgtm

Don't forget to add new files to components/gcm_driver/BUILD.gn.

https://codereview.chromium.org/551163002/diff/40001/components/gcm_driver/gc...
File components/gcm_driver/gcm_delayed_task_controller_unittest.cc (right):

https://codereview.chromium.org/551163002/diff/40001/components/gcm_driver/gc...
components/gcm_driver/gcm_delayed_task_controller_unittest.cc:53:
TEST_F(GCMDelayedTaskControllerTest, PendingTasksTriggeredWhenSetReady) {
I think we can combine all these 3 tests into one since we're not testing
multiple aspects of this class:

TEST_F(...) {
  EXPECT_FALSE(controller()->CanRunTaskWithoutDelay());
  EXPECT_EQ(0, number_of_triggered_tasks());

  controller()->AddTask(...);
  controller()->AddTask(...);

  controller()->SetReady();
  EXPECT_TRUE(controller()->CanRunTaskWithoutDelay());
  EXPECT_EQ(2, number_of_triggered_tasks());
}

[fgorski, 2014-09-09 23:11:43]

Updated

https://codereview.chromium.org/551163002/diff/40001/components/gcm_driver/gc...
File components/gcm_driver/gcm_delayed_task_controller_unittest.cc (right):

https://codereview.chromium.org/551163002/diff/40001/components/gcm_driver/gc...
components/gcm_driver/gcm_delayed_task_controller_unittest.cc:53:
TEST_F(GCMDelayedTaskControllerTest, PendingTasksTriggeredWhenSetReady) {
On 2014/09/09 19:53:18, jianli wrote:
> I think we can combine all these 3 tests into one since we're not testing
> multiple aspects of this class:
> 
> TEST_F(...) {
>   EXPECT_FALSE(controller()->CanRunTaskWithoutDelay());
>   EXPECT_EQ(0, number_of_triggered_tasks());
> 
>   controller()->AddTask(...);
>   controller()->AddTask(...);
> 
>   controller()->SetReady();
>   EXPECT_TRUE(controller()->CanRunTaskWithoutDelay());
>   EXPECT_EQ(2, number_of_triggered_tasks());
> }

Done. I went down to 2, because I didn't want to call SetReady twice.

[fgorski, 2014-09-09 23:11:46]

The CQ bit was checked by fgorski@chromium.org

[commit-bot: I haz the power, 2014-09-09 23:25:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fgorski@chromium.org/551163002/60001

[commit-bot: I haz the power, 2014-09-10 01:53:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-10 01:53:32]

Try jobs failed on following builders:
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[fgorski, 2014-09-10 16:32:44]

The CQ bit was checked by fgorski@chromium.org

[commit-bot: I haz the power, 2014-09-10 16:34:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fgorski@chromium.org/551163002/60001

[commit-bot: I haz the power, 2014-09-10 17:30:06]

Committed patchset #4 (id:60001) as 1c932af6c3828b5a4e9d11e7e551724dee9679fd

[commit-bot: I haz the power, 2014-09-10 17:35:44]

Patchset 4 (id:??) landed as
https://crrev.com/05d507c5ff8d67311e264c2ee9c9edc4729346b1
Cr-Commit-Position: refs/heads/master@{#294185}