Issue 551105: Fix browser crash in extensions due to painting badges on PageActions....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 551105: Fix browser crash in extensions due to painting badges on PageActions.... (Closed)

Created:
10 years, 11 months ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix browser crash in extensions due to painting badges on PageActions. It is possible this will move the crash location elsewhere, but since we don't even support showing badges on PageActions, we have no reason to attempt it. BUG=http://crbug.com/31080 TEST=Monitor the crash rate and see if the crash is fixed. Badges should still work on BrowserActions. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36807

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -15 lines)			Patch
	M	chrome/browser/views/location_bar_view.cc	View	1	3 chunks	+3 lines, -15 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

10 years, 11 months ago (2010-01-21 23:10:58 UTC) #2

lgtm with nit

http://codereview.chromium.org/551105/diff/1002/2001
File chrome/browser/views/location_bar_view.cc (right):

http://codereview.chromium.org/551105/diff/1002/2001#newcode78
chrome/browser/views/location_bar_view.cc:78: virtual ~PageActionWithBadgeView()
{}
~View is virtual so I don't think this is necessary.

Expand Messages | Collapse Messages