Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1305)

Unified Diff: content/public/browser/BUILD.gn

Issue 551103002: Work on "gn check" of content/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/app/content_main_delegate.cc ('k') | content/public/child/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/BUILD.gn
diff --git a/content/public/browser/BUILD.gn b/content/public/browser/BUILD.gn
index a9534846ffe0f3e76f9e7e5b28e403395c40f1c7..c51628fbf852baa5ea767ffac549db9478a69859 100644
--- a/content/public/browser/BUILD.gn
+++ b/content/public/browser/BUILD.gn
@@ -9,12 +9,12 @@ group("browser") {
if (is_component_build) {
deps = [ "//content" ]
} else {
- deps = [ ":sources" ]
+ deps = [ ":browser_sources" ]
}
forward_dependent_configs_from = deps
}
-source_set("sources") {
+source_set("browser_sources") {
if (is_ios) {
# iOS doesn't get the normal file list and only takes these whitelisted
# files.
@@ -40,7 +40,18 @@ source_set("sources") {
deps = [
"//content/browser",
+ "//content/public/common",
+ "//net",
"//skia",
+ "//ui/accessibility",
+ "//ui/base",
+ "//ui/events",
+ ]
+
+ allow_circular_includes_from = [
+ # This target is a pair with content/browser. They always go together and
+ # include headers from each other.
+ "//content/browser",
]
# We expose skia headers in the public API.
« no previous file with comments | « content/public/app/content_main_delegate.cc ('k') | content/public/child/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698