Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 551103002: Work on "gn check" of content/* (Closed)

Created:
6 years, 3 months ago by brettw
Modified:
6 years, 3 months ago
Reviewers:
scottmg
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/e7487946ffbd0ab4d331d6ff664e4553629b643d Cr-Commit-Position: refs/heads/master@{#294036}

Patch Set 1 #

Patch Set 2 : tweaks #

Patch Set 3 : merge #

Total comments: 4

Patch Set 4 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -20 lines) Patch
M content/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/BUILD.gn View 1 2 chunks +5 lines, -0 lines 0 comments Download
M content/content_renderer.gypi View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M content/public/app/BUILD.gn View 1 2 3 4 chunks +55 lines, -14 lines 0 comments Download
M content/public/app/content_main_delegate.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/browser/BUILD.gn View 1 2 3 2 chunks +13 lines, -2 lines 0 comments Download
M content/public/child/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
M content/public/plugin/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/renderer/BUILD.gn View 1 1 chunk +8 lines, -0 lines 0 comments Download
M content/public/utility/BUILD.gn View 1 1 chunk +7 lines, -0 lines 0 comments Download
M content/renderer/BUILD.gn View 1 2 3 3 chunks +6 lines, -1 line 0 comments Download
M content/test/BUILD.gn View 1 2 3 3 chunks +5 lines, -0 lines 0 comments Download
M content/utility/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
brettw
6 years, 3 months ago (2014-09-08 19:49:43 UTC) #2
brettw
Trung is out today, Scott?
6 years, 3 months ago (2014-09-08 23:20:33 UTC) #4
scottmg
lgtm https://codereview.chromium.org/551103002/diff/40001/content/public/app/BUILD.gn File content/public/app/BUILD.gn (right): https://codereview.chromium.org/551103002/diff/40001/content/public/app/BUILD.gn#newcode77 content/public/app/BUILD.gn:77: # TODO(brettw) either teach the header checker to ...
6 years, 3 months ago (2014-09-09 04:09:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/551103002/60001
6 years, 3 months ago (2014-09-09 19:58:27 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/11798)
6 years, 3 months ago (2014-09-09 22:05:58 UTC) #9
brettw
Committed patchset #4 (id:60001) to pending queue manually as b7e48ee (presubmit successful).
6 years, 3 months ago (2014-09-09 23:39:18 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:56:33 UTC) #11
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/e7487946ffbd0ab4d331d6ff664e4553629b643d
Cr-Commit-Position: refs/heads/master@{#294036}

Powered by Google App Engine
This is Rietveld 408576698