Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 551083002: Make GrEffectStage copy constructor work correctly with pending execution refs. (Closed)

Created:
6 years, 3 months ago by bsalomon
Modified:
6 years, 3 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Make GrEffectStage copy constructor work correctly with pending execution refs. Committed: https://skia.googlesource.com/skia/+/655ad128d054005ce5e55cc6f0b75a4dec07ccce

Patch Set 1 #

Patch Set 2 : revert whitespace change #

Patch Set 3 : fix #

Patch Set 4 : ; #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -6 lines) Patch
M include/gpu/GrEffectStage.h View 2 chunks +6 lines, -6 lines 0 comments Download
M include/gpu/GrProgramElementRef.h View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
bsalomon
6 years, 3 months ago (2014-09-08 18:44:07 UTC) #2
egdaniel
lgtm
6 years, 3 months ago (2014-09-08 18:53:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/551083002/60001
6 years, 3 months ago (2014-09-08 19:00:08 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-08 19:06:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as 655ad128d054005ce5e55cc6f0b75a4dec07ccce

Powered by Google App Engine
This is Rietveld 408576698