Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(876)

Issue 551073005: Reland: Force calling PostDisplayConfigurationChange() even if earyling out in UpdateDisplays (Closed)

Created:
6 years, 3 months ago by Yufeng Shen (Slow to review)
Modified:
6 years, 3 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Reland: Force calling PostDisplayConfigurationChange() even if earyling out in UpdateDisplays When changing from software mirroring mode to sinlge display mode, it is possible there is no need to update |displays_| and we early out UpdateDisplays(). But we still want to run the PostDisplayConfigurationChange() cause there are some clients need to act on this, e.g. TouchTransformerController needs to adjust the TouchTransformer when switching from dual displays to single display. BUG=chrome-os-partner:31868 TEST=tested on Big, after existing software mirroring mode, the touch location transformation is still correct. TBR=oshima@chromium.org Committed: https://crrev.com/2c7fdae75971a3352f0b29a1a0672cc09050738e Cr-Commit-Position: refs/heads/master@{#294908}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -8 lines) Patch
M ash/display/display_controller_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/display/display_manager.cc View 2 chunks +16 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Yufeng Shen (Slow to review)
This is relanding https://codereview.chromium.org/559213002/
6 years, 3 months ago (2014-09-15 20:26:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/551073005/1
6 years, 3 months ago (2014-09-15 20:32:41 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 6e459d9005b4c23623239e7ae69069fe65efdb2d
6 years, 3 months ago (2014-09-15 22:50:23 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 22:52:53 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c7fdae75971a3352f0b29a1a0672cc09050738e
Cr-Commit-Position: refs/heads/master@{#294908}

Powered by Google App Engine
This is Rietveld 408576698