tools/telemetry/telemetry/value/__init__.py - Issue 551063005: [Telemetry] Fix handling for two-part per-page value names in Chart JSON.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/value/init.py

Issue 551063005: [Telemetry] Fix handling for two-part per-page value names in Chart JSON. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/value/__init__.py

diff --git a/tools/telemetry/telemetry/value/__init__.py b/tools/telemetry/telemetry/value/__init__.py

index 490356308c48836317caec8f86ba757cfb2b80ff..c4330ecdd92c5da1a3b24217ed9d5e43b2840694 100644

--- a/tools/telemetry/telemetry/value/__init__.py

+++ b/tools/telemetry/telemetry/value/__init__.py

@@ -132,7 +132,8 @@ class Value(object):

def GetChartAndTraceNameForPerPageResult(self):

chart_name, _ = _ConvertValueNameToChartAndTraceName(self.name)

- return chart_name, self.page.display_name

+ trace_name = self.page.display_name

+ return chart_name, trace_name

@property

def name_suffix(self):

« no previous file with comments | « tools/telemetry/telemetry/results/chart_json_output_formatter_unittest.py ('k') | no next file » | no next file with comments »

Unified Diff: tools/telemetry/telemetry/value/__init__.py

Unified Diff: tools/telemetry/telemetry/value/init.py