Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: tools/telemetry/telemetry/results/chart_json_output_formatter.py

Issue 551063005: [Telemetry] Fix handling for two-part per-page value names in Chart JSON. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/results/chart_json_output_formatter_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/results/chart_json_output_formatter.py
diff --git a/tools/telemetry/telemetry/results/chart_json_output_formatter.py b/tools/telemetry/telemetry/results/chart_json_output_formatter.py
index 065bbc24e63c705d93db037dcc310de070661b7e..6ba8f21c344703fc464935fe4b782e4c256698c3 100644
--- a/tools/telemetry/telemetry/results/chart_json_output_formatter.py
+++ b/tools/telemetry/telemetry/results/chart_json_output_formatter.py
@@ -38,16 +38,16 @@ def _ResultsAsChartDict(benchmark_metadata, page_specific_values,
for value in values:
if value.page:
- chart_name, trace_name = (
- value.GetChartAndTraceNameForPerPageResult())
+ chart_name, trace_name = (value.GetChartAndTraceNameForPerPageResult())
else:
chart_name, trace_name = (
value.GetChartAndTraceNameForComputedSummaryResult(None))
if chart_name == trace_name:
trace_name = 'summary'
- assert trace_name not in charts[chart_name]
-
+ # This intentionally overwrites the trace if it already exists because this
+ # is expected of output from the buildbots currently.
+ # See: crbug.com/413393
charts[chart_name][trace_name] = value.AsDict()
result_dict = {
« no previous file with comments | « no previous file | tools/telemetry/telemetry/results/chart_json_output_formatter_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698