Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 551063002: Attempted fix for refcount in sideloaded font path (Closed)

Created:
6 years, 3 months ago by scottmg
Modified:
6 years, 3 months ago
Reviewers:
bungeman-chromium, eae
CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Project:
blink
Visibility:
Public.

Description

Attempted fix for refcount in sideloaded font path Followup to buggy code added in http://src.chromium.org/viewvc/blink?view=rev&rev=181407 . This code path is only used in layout tests. TBR=eae@chromium.org R=bungeman@chromium.org BUG=394902 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181587

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/platform/fonts/win/FontCacheSkiaWin.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
scottmg
6 years, 3 months ago (2014-09-08 17:47:18 UTC) #1
bungeman-chromium
lgtm
6 years, 3 months ago (2014-09-08 17:49:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/551063002/1
6 years, 3 months ago (2014-09-08 17:52:01 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/26078)
6 years, 3 months ago (2014-09-08 22:03:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/551063002/1
6 years, 3 months ago (2014-09-08 22:10:59 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 181587
6 years, 3 months ago (2014-09-09 00:07:34 UTC) #10
Stephen White
6 years, 3 months ago (2014-09-09 12:05:08 UTC) #11
Message was sent while issue was closed.
On 2014/09/09 00:07:34, I haz the power (commit-bot) wrote:
> Committed patchset #1 (id:1) as 181587

Drive-by peanut: we try to adoptRef() the bare pointers returned by Skia
constructors or factory methods directly into RefPtrs at the place where the new
Skia object is created (ie., the call to the constructor or create() factory),
and then use RefPtr and PassRefPtr from there to indicate ownership transfer. I
don't know if that's possible in your case, since the code crosses the
Chrome/Blink API, but I thought I'd mention it.

Powered by Google App Engine
This is Rietveld 408576698