Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 551043005: Added CallInterfaceDescriptors to all code stubs. (Closed)

Created:
6 years, 3 months ago by mvstanton
Modified:
6 years, 3 months ago
Reviewers:
Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Added CallInterfaceDescriptors to all code stubs. A handful of code stubs are too complex to be described this way, and they are encoded with the macro DEFINE_NULL_CALL_INTERFACE_DESCRIPTOR(). Along the way: * allowed inheritance of CallInterfaceDescriptors. * Defined static Register methods for some of the new CallInterfaceDescriptors. We could go a lot further here, but it doesn't have to be done immediately. * Added Representation arrays to some CallInterfaceDescriptors, especially where future hydrogen versions of the stubs could benefit from this knowledge. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23854

Patch Set 1 #

Patch Set 2 : Altered a macro. #

Patch Set 3 : Removed CEntryCallDescriptor and x64 port. #

Patch Set 4 : All ports. #

Patch Set 5 : REBASE. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+440 lines, -185 lines) Patch
M src/arm/code-stubs-arm.h View 1 2 3 4 4 chunks +5 lines, -0 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 2 3 4 3 chunks +6 lines, -2 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 2 3 3 chunks +30 lines, -21 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 2 3 1 chunk +4 lines, -3 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 2 3 4 2 chunks +5 lines, -3 lines 0 comments Download
M src/arm64/code-stubs-arm64.h View 1 2 3 4 5 chunks +6 lines, -0 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 3 4 3 chunks +10 lines, -5 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 2 3 5 chunks +31 lines, -24 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 1 2 3 4 1 chunk +8 lines, -5 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 2 3 4 3 chunks +9 lines, -6 lines 0 comments Download
M src/code-stubs.h View 1 2 3 4 26 chunks +60 lines, -5 lines 0 comments Download
M src/ia32/code-stubs-ia32.h View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 3 4 3 chunks +5 lines, -1 line 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 2 3 3 chunks +31 lines, -22 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 2 3 4 2 chunks +5 lines, -3 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/ic/arm/handler-compiler-arm.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/interface-descriptors.h View 1 2 3 4 7 chunks +122 lines, -48 lines 0 comments Download
M src/interface-descriptors.cc View 1 2 3 1 chunk +45 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.h View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 3 4 4 chunks +6 lines, -3 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 2 3 3 chunks +31 lines, -22 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 2 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mvstanton
Hi Yang, Here is a CL that makes it mandatory for even the PlatformCodeStubs to ...
6 years, 3 months ago (2014-09-09 11:40:49 UTC) #2
mvstanton
Okay, ports addressed.
6 years, 3 months ago (2014-09-09 15:11:08 UTC) #3
Yang
lgtm!
6 years, 3 months ago (2014-09-10 14:57:53 UTC) #4
mvstanton
6 years, 3 months ago (2014-09-11 07:11:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #5 (id:100001) manually as 23854 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698